Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small summary mistake #21855

Closed
AndreasCag opened this issue May 21, 2017 · 3 comments
Closed

Small summary mistake #21855

AndreasCag opened this issue May 21, 2017 · 3 comments
Assignees
@AndreasCag
Labels
area-System.Runtime documentation Documentation bug or enhancement, does not impact product or test code good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
2.1.0

Comments

@AndreasCag
Copy link
Contributor

https://github.com/dotnet/corefx/blob/master/src/System.ValueTuple/src/System/ValueTuple/ValueTuple.cs#L446
Change "first" to "second".
@svick
Copy link
Contributor

svick commented May 21, 2017

Do you want to create a Pull Request that fixes it?

It's fairly simple: start by clicking on the pencil icon at the top of the file.

@karelz
Copy link
Member

karelz commented May 22, 2017

Here are docs (under construction) for first PR: https://github.com/dotnet/corefx/wiki/New-contributor-Docs#contributing-guide

@stephentoub
Copy link
Member

Fixed in dotnet/corefx#20090

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndreasCag AndreasCag

Labels
area-System.Runtime documentation Documentation bug or enhancement, does not impact product or test code good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
5 participants
@svick @stephentoub @karelz @msftgits @AndreasCag