Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP: System.Net.Sockets #21885

Closed
CIPop opened this issue May 22, 2017 · 6 comments
Closed

UWP: System.Net.Sockets #21885

CIPop opened this issue May 22, 2017 · 6 comments
Assignees
Milestone

Comments

@CIPop
Copy link
Member

CIPop commented May 22, 2017

Tracking work for System.Net.Sockets in UWP

@caesar-chen caesar-chen self-assigned this Jun 5, 2017
@caesar-chen
Copy link
Contributor

caesar-chen commented Jun 22, 2017

I'm doing the final revision for S.N.Sockets Functional tests, and I have a question. For LoggingTests, I am not able to find an issue to disable it (I was using this epic number before). What number should I use?
dotnet/corefx#21019 (comment)

@davidsh @CIPop

@CIPop
Copy link
Member Author

CIPop commented Jun 22, 2017

@Caesar1995 I think it's dotnet/corefx#20470

@caesar-chen
Copy link
Contributor

caesar-chen commented Jun 23, 2017

Status update:

I will start UWP: System.Net.NetworkInformation work.

UPDATE: dotnet/corefx#21158 has been fixed
UPDATE2: dotnet/corefx#21391 is a dupe of dotnet/corefx#20470
UPDATE3: Delete the not needed PAL files

@caesar-chen caesar-chen removed their assignment Jun 23, 2017
@caesar-chen
Copy link
Contributor

Sorry I made a mistake, CompletionPortHelper.Uap.cs cannot be removed, while ContextAwareResult.Uap.cs can be removed.

Analysis:
For SafeCloseSocket Windows' implementation, we need CompletionPortHelper.SkipCompletionPortOnSuccess() to decide whether we need to disable completions for synchronous success. [CompletionPortHelper.SkipCompletionPortOnSuccess() is using an api (Interop.Kernel32.SetFileCompletionNotificationModes) which has not been approved for UAP yet. That's why we need the PAL for CompletionPortHelper.

While ContextAwareResult.Uap.cs doesn't has this problem and can be removed.

I will submit a PR to correct my mistake.

cc: @CIPop @davidsh @DavidGoll

@CIPop
Copy link
Member Author

CIPop commented Jun 28, 2017

SetFileCompletionNotificationModes which has not been approved for UAP yet

@Caesar1995 @DavidGoll I believe the synchronous completion mode for Sockets enhancement was added after we had the UAP profile discussions and analyzed the API surface.
Let's follow-up offline. Ideally we should have the same implementation for both Windows Desktop and UAP.

@caesar-chen
Copy link
Contributor

I wasn't aware that the API has been approved.

Last time I built the project without the CompletionPortHelper.Uap.cs in UAP mode, the compiler complained that "error: SetFileCompletionNotificationModes() is not supported on UAP". But now the error goes away. I will delete both of the files.

@CIPop CIPop closed this as completed Jul 12, 2017
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants