-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Selectively strip the Name section of the wasm blob #43690
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
@CoffeeFlux it is much more useful to speak in terms of compressed size for metrics like this. |
Stripping all the debug information via wasm-opt --strip-debug which removes more than the name section produces:
Which is worth noting in the sense that the names/debug information clearly compressed more than the bulk of dotnet.wasm |
@kg thoughts on how difficult it would be to strip all names matching a regex while preserving the rest? |
Very easy, we'd eat an extra byte or two of filler for the stripped names worst case but it'll compress out |
@tqiu8 please prioritize |
This is no longer an issue due to #43951, which uses wasm-opt from emscripten to strip out the custom section including names. This will not affect the debugger performance. |
Currently, this section takes up about 150K without ICU and 550K with ICU. For a minimal sample we should get rid of everything other than a handful of functions. For the normal build we should get rid of the ICU symbols other than the ones we call directly since they are of little benefit to us in stack traces. See https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#name-section
The text was updated successfully, but these errors were encountered: