Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Experiment with getting rid of SHA1Transform in the runtime #43693

Closed
CoffeeFlux opened this issue Oct 21, 2020 · 4 comments
Closed

[wasm] Experiment with getting rid of SHA1Transform in the runtime #43693

CoffeeFlux opened this issue Oct 21, 2020 · 4 comments
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone
Future

Comments

@CoffeeFlux
Copy link
Contributor

This is currently kept alive due to public key token generation, which is done on assembly load. Is this accessed only from managed, in which case we could just avoid calculating it on the native side? Could we precompute this as part of the bundle?
@CoffeeFlux CoffeeFlux added arch-wasm WebAssembly architecture area-VM-meta-mono labels Oct 21, 2020
@CoffeeFlux CoffeeFlux added this to the Future milestone Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 21, 2020
@CoffeeFlux CoffeeFlux removed the untriaged New issue has not been triaged by the area owner label Oct 21, 2020
@SamMonoRT SamMonoRT mentioned this issue Oct 23, 2020
Open
23 tasks
@marek-safar marek-safar added the size-reduction Issues impacting final app size primary for size sensitive workloads label Dec 17, 2020
@lewing
Copy link
Member

lewing commented Jun 17, 2021

@CoffeeFlux did this every go anywhere?

@CoffeeFlux
Copy link
Contributor Author

I think I looked into it but there ended up being some complicating factor. Maybe we needed the property computation to be lazier? Either way, there's nothing concrete as a result of this.

@lewing
Copy link
Member

lewing commented Feb 9, 2024

calling this closed

@lewing lewing closed this as completed Feb 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@lewing @marek-safar @CoffeeFlux @Dotnet-GitSync-Bot