-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on USE_ZLIB from browser wasm build #45454
Comments
We should at some point reduce the two zlibs in our tree to a single copy. Looks like they're identical versions, but the libraries one has some extra files. |
For my own reference, here's what we have in the repo currently: src\libraries\Native\Windows\System.IO.Compression.Native\zlib src\mono\mono\zlib src\libraries\Native\Windows\System.IO.Compression.Native\zlib-intel |
This is used by the mono in this repo on platforms that don't ship a system zlib like WASM or Win32. |
Now that the mirror is off, it should be safe to get rid of the Mono-specific copy of zlib, assuming it's identical to the one in libraries. However, like @akoeplinger mentioned, we do it need for some platforms so we can't get rid of both copies altogether. This is somewhat separate from getting rid of |
The We also still have duplication in the build tree, but it's not particularly urgent. |
This special flag causes the emscripten toolchain to download and build a .zip version of zlib from https://github.com/emscripten-ports/zlib which unnecessarily introduces a network dependency into the build.
We already have a zlib implementation in mono that we can use.
Note that zlib is used both inside of mono and System.Native, we need to make sure only one copy of zlib makes it into the dotnet.wasm.
Three parts to this:
The text was updated successfully, but these errors were encountered: