Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Remove w32 subsystem on wasm #48056

Closed
CoffeeFlux opened this issue Feb 9, 2021 · 4 comments
Closed

[mono] Remove w32 subsystem on wasm #48056

CoffeeFlux opened this issue Feb 9, 2021 · 4 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone

Comments

@CoffeeFlux
Copy link
Contributor

CoffeeFlux commented Feb 9, 2021

This runtime code (w32* files) should be largely unnecessary for netcore after #47333 lands, and we should get rid of it as much as possible and make sure it's not present on wasm. If we do use it in a single place, it might be worth some refactoring to put the relevant code elsewhere.

@CoffeeFlux CoffeeFlux added this to the 6.0.0 milestone Feb 9, 2021
@ghost
Copy link

ghost commented Feb 9, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

This code should be largely unnecessary for netcore after #47333 lands, and we should get rid of it as much as possible and make sure it's not present on wasm.

Author: CoffeeFlux
Assignees: -
Labels:

area-VM-meta-mono

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 9, 2021
@CoffeeFlux CoffeeFlux removed the untriaged New issue has not been triaged by the area owner label Feb 9, 2021
@CoffeeFlux CoffeeFlux added arch-wasm WebAssembly architecture size-reduction Issues impacting final app size primary for size sensitive workloads labels Feb 16, 2021
@ghost
Copy link

ghost commented Feb 16, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This runtime code (w32* files) should be largely unnecessary for netcore after #47333 lands, and we should get rid of it as much as possible and make sure it's not present on wasm. If we do use it in a single place, it might be worth some refactoring to put the relevant code elsewhere.

Author: CoffeeFlux
Assignees: -
Labels:

arch-wasm, area-VM-meta-mono, size-reduction

Milestone: 6.0.0

@CoffeeFlux CoffeeFlux self-assigned this Feb 16, 2021
@CoffeeFlux
Copy link
Contributor Author

CoffeeFlux commented Feb 26, 2021

Some of this is held alive by EventPipe, and that will need to be refactored out. Otherwise, a lot will go away with #47333

@CoffeeFlux
Copy link
Contributor Author

This is mostly done, so I think we're good here. The remaining bits are either held by EventPipe or Monitor.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

No branches or pull requests

1 participant