Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMI coreclr test collection issue #75931

Closed
AndyAyersMS opened this issue Sep 20, 2022 · 4 comments
Closed

SPMI coreclr test collection issue #75931

AndyAyersMS opened this issue Sep 20, 2022 · 4 comments
Assignees
@BruceForstall
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
8.0.0

Comments

@AndyAyersMS
Copy link
Member

Test collection is almost clean, just one failure remains.

https://dev.azure.com/dnceng/internal/_build/results?buildId=1997174&view=results

Possibly what's happening here is that the helix partitioning is not copying over the right test assets. This test is a bit unusual in that it ends up invoking other tests. Note one of these invocations fails and the other doesn't.

Not sure if/how the partitioning done here differs from the normal coreclr test runs; seems like they would have the same problem.

The missing test case is under JIT/methodical...

  Starting:    JIT.superpmi.XUnitWrapper (parallel test collections = on, max threads = 4)
    JIT/superpmi/superpmicollect/superpmicollect.sh [FAIL]
      Can't open /root/helix/work/workitem/e/JIT/superpmi/superpmicollect/10w5d_cs_do/10w5d_cs_do.sh: No such file or directory.
      /bin/chmod: cannot access '/root/helix/work/workitem/e/JIT/superpmi/superpmicollect/10w5d_cs_do/10w5d_cs_do.sh': No such file or directory
      bash: /root/helix/work/workitem/e/JIT/superpmi/superpmicollect/10w5d_cs_do/10w5d_cs_do.sh: No such file or directory
      ERROR: no .mc files generated
      
      Return code:      1
      Raw output file:      /root/helix/work/workitem/uploads/Reports/JIT.superpmi/superpmicollect/superpmicollect.output.txt
      Raw output:
      BEGIN EXECUTION
      /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false superpmicollect.dll ''
      SuperPMI collection and playback - BEGIN
      Setting environment variables:
          SuperPMIShimLogPath=/tmp/2b1nqxko.5avSPMI
          SuperPMIShimPath=/root/helix/work/correlation/libclrjit.so
          COMPlus_JitName=libsuperpmi-shim-collector.so
      Running: /usr/bin/perl -pi -e 's/\r\n|\n|\r/\n/g' "/root/helix/work/workitem/e/JIT/superpmi/superpmicollect/Bytemark/Bytemark.sh"
      Running: /bin/chmod +x "/root/helix/work/workitem/e/JIT/superpmi/superpmicollect/Bytemark/Bytemark.sh"
      Running: /usr/bin/env bash /root/helix/work/workitem/e/JIT/superpmi/superpmicollect/Bytemark/Bytemark.sh
      BEGIN EXECUTION
      /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false Bytemark.dll ''
      BBBBBB   YYY   Y  TTTTTTT  EEEEEEE
      BBB   B  YYY   Y    TTT    EEE
      BBB   B  YYY   Y    TTT    EEE
      BBBBBB    YYY Y     TTT    EEEEEEE
      BBB   B    YYY      TTT    EEE
      BBB   B    YYY      TTT    EEE
      BBBBBB     YYY      TTT    EEEEEEE

... snip ...

  Finished:    JIT.superpmi.XUnitWrapper
=== TEST EXECUTION SUMMARY ===
   JIT.BBT.XUnitWrapper            Total:   1, Errors: 0, Failed: 0, Skipped: 0, Time:   1.534s
   JIT.CheckProjects.XUnitWrapper  Total:   1, Errors: 0, Failed: 0, Skipped: 0, Time:   0.818s
   JIT.opt.XUnitWrapper            Total: 246, Errors: 0, Failed: 0, Skipped: 0, Time:  60.640s
   JIT.Performance.XUnitWrapper    Total: 101, Errors: 0, Failed: 0, Skipped: 0, Time:  82.628s
   JIT.RyuJIT.XUnitWrapper         Total:   1, Errors: 0, Failed: 0, Skipped: 0, Time:   0.725s
   JIT.superpmi.XUnitWrapper       Total:   2, Errors: 0, Failed: 1, Skipped: 0, Time:  84.633s
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 20, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 20, 2022
@ghost
Copy link

ghost commented Sep 20, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Test collection is almost clean, just one failure remains.

https://dev.azure.com/dnceng/internal/_build/results?buildId=1997174&view=results

Possibly what's happening here is that the helix partitioning is not copying over the right test assets. This test is a bit unusual in that it ends up invoking other tests. Note one of these invocations fails and the other doesn't.

Not sure if/how the partitioning done here differs from the normal coreclr test runs; seems like they would have the same problem.

The missing test case is under JIT/methodical...

  Starting:    JIT.superpmi.XUnitWrapper (parallel test collections = on, max threads = 4)
    JIT/superpmi/superpmicollect/superpmicollect.sh [FAIL]
      Can't open /root/helix/work/workitem/e/JIT/superpmi/superpmicollect/10w5d_cs_do/10w5d_cs_do.sh: No such file or directory.
      /bin/chmod: cannot access '/root/helix/work/workitem/e/JIT/superpmi/superpmicollect/10w5d_cs_do/10w5d_cs_do.sh': No such file or directory
      bash: /root/helix/work/workitem/e/JIT/superpmi/superpmicollect/10w5d_cs_do/10w5d_cs_do.sh: No such file or directory
      ERROR: no .mc files generated
      
      Return code:      1
      Raw output file:      /root/helix/work/workitem/uploads/Reports/JIT.superpmi/superpmicollect/superpmicollect.output.txt
      Raw output:
      BEGIN EXECUTION
      /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false superpmicollect.dll ''
      SuperPMI collection and playback - BEGIN
      Setting environment variables:
          SuperPMIShimLogPath=/tmp/2b1nqxko.5avSPMI
          SuperPMIShimPath=/root/helix/work/correlation/libclrjit.so
          COMPlus_JitName=libsuperpmi-shim-collector.so
      Running: /usr/bin/perl -pi -e 's/\r\n|\n|\r/\n/g' "/root/helix/work/workitem/e/JIT/superpmi/superpmicollect/Bytemark/Bytemark.sh"
      Running: /bin/chmod +x "/root/helix/work/workitem/e/JIT/superpmi/superpmicollect/Bytemark/Bytemark.sh"
      Running: /usr/bin/env bash /root/helix/work/workitem/e/JIT/superpmi/superpmicollect/Bytemark/Bytemark.sh
      BEGIN EXECUTION
      /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false Bytemark.dll ''
      BBBBBB   YYY   Y  TTTTTTT  EEEEEEE
      BBB   B  YYY   Y    TTT    EEE
      BBB   B  YYY   Y    TTT    EEE
      BBBBBB    YYY Y     TTT    EEEEEEE
      BBB   B    YYY      TTT    EEE
      BBB   B    YYY      TTT    EEE
      BBBBBB     YYY      TTT    EEEEEEE

... snip ...

  Finished:    JIT.superpmi.XUnitWrapper
=== TEST EXECUTION SUMMARY ===
   JIT.BBT.XUnitWrapper            Total:   1, Errors: 0, Failed: 0, Skipped: 0, Time:   1.534s
   JIT.CheckProjects.XUnitWrapper  Total:   1, Errors: 0, Failed: 0, Skipped: 0, Time:   0.818s
   JIT.opt.XUnitWrapper            Total: 246, Errors: 0, Failed: 0, Skipped: 0, Time:  60.640s
   JIT.Performance.XUnitWrapper    Total: 101, Errors: 0, Failed: 0, Skipped: 0, Time:  82.628s
   JIT.RyuJIT.XUnitWrapper         Total:   1, Errors: 0, Failed: 0, Skipped: 0, Time:   0.725s
   JIT.superpmi.XUnitWrapper       Total:   2, Errors: 0, Failed: 1, Skipped: 0, Time:  84.633s
Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS AndyAyersMS added this to the 8.0.0 milestone Sep 20, 2022
@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label Sep 20, 2022
@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

@BruceForstall BruceForstall self-assigned this Sep 28, 2022
@BruceForstall
Copy link
Member

I'll look into the partitioning issue (that's not related to SPMI collection runs). However, this test shouldn't be run during a SPMI collection, which is fixed by #76311

@BruceForstall
Copy link
Member

It turns out the missing .cmd file is a latent, incorrectly ignored, build failure, not a partitioning error. I've opened #76421 to track.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@AndyAyersMS @BruceForstall