Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.IO.Compression.Brotli #79410

Closed
performanceautofiler bot opened this issue Dec 8, 2022 · 5 comments
Closed

Regressions in System.IO.Compression.Brotli #79410

performanceautofiler bot opened this issue Dec 8, 2022 · 5 comments
Assignees
@EgorBo
Labels
area-System.IO.Compression tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
Future

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 53568571ac9a32608136aac54fafcf580ee47fa2
Compare 91f114b5364dd06c40f7f240827162d9f2a8a5cf
Diff Diff

Regressions in System.IO.Compression.Brotli

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Compress_WithoutState - Duration of single invocation 524.56 ms 557.64 ms 1.06 0.00 False
Compress_WithState - Duration of single invocation 524.86 ms 557.70 ms 1.06 0.00 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.IO.Compression.Brotli*'

Payloads

Baseline
Compare

Histogram

System.IO.Compression.Brotli.Compress_WithoutState(level: Optimal, file: "TestDocument.pdf")

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 557.64172 > 550.509544.
IsChangePoint: Marked as a change because one of 9/7/2022 12:22:27 PM, 11/30/2022 3:45:04 PM, 12/8/2022 3:49:24 AM falls between 11/29/2022 2:55:01 PM and 12/8/2022 3:49:24 AM.
IsRegressionStdDev: Marked as regression because -323.53610647052784 (T) = (0 -557201585.5477856) / Math.Sqrt((76324154956.49907 / (13)) + (100583807224.27371 / (22))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (22) - 2, .025) and -0.06307984225933665 = (524138981.28627783 - 557201585.5477856) / 524138981.28627783 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Compression.Brotli.Compress_WithState(level: Optimal, file: "TestDocument.pdf")

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 557.69502 > 550.1916858846154.
IsChangePoint: Marked as a change because one of 9/7/2022 12:22:27 PM, 11/30/2022 3:45:04 PM, 12/8/2022 3:49:24 AM falls between 11/29/2022 2:55:01 PM and 12/8/2022 3:49:24 AM.
IsRegressionStdDev: Marked as regression because -330.3355798255706 (T) = (0 -557274718.5647686) / Math.Sqrt((98028916897.25769 / (13)) + (54037767667.19625 / (22))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (22) - 2, .025) and -0.06300191913979473 = (524246201.75260633 - 557274718.5647686) / 524246201.75260633 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels Dec 8, 2022
@cincuranet cincuranet removed refs/heads/main untriaged New issue has not been triaged by the area owner labels Dec 8, 2022
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Dec 8, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 8, 2022
@ghost
Copy link

ghost commented Dec 8, 2022

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 53568571ac9a32608136aac54fafcf580ee47fa2
Compare 91f114b5364dd06c40f7f240827162d9f2a8a5cf
Diff Diff

Regressions in System.IO.Compression.Brotli

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Compress_WithoutState - Duration of single invocation 524.56 ms 557.64 ms 1.06 0.00 False
Compress_WithState - Duration of single invocation 524.86 ms 557.70 ms 1.06 0.00 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.IO.Compression.Brotli*'

Payloads

Baseline
Compare

Histogram

System.IO.Compression.Brotli.Compress_WithoutState(level: Optimal, file: "TestDocument.pdf")

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 557.64172 > 550.509544.
IsChangePoint: Marked as a change because one of 9/7/2022 12:22:27 PM, 11/30/2022 3:45:04 PM, 12/8/2022 3:49:24 AM falls between 11/29/2022 2:55:01 PM and 12/8/2022 3:49:24 AM.
IsRegressionStdDev: Marked as regression because -323.53610647052784 (T) = (0 -557201585.5477856) / Math.Sqrt((76324154956.49907 / (13)) + (100583807224.27371 / (22))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (22) - 2, .025) and -0.06307984225933665 = (524138981.28627783 - 557201585.5477856) / 524138981.28627783 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Compression.Brotli.Compress_WithState(level: Optimal, file: "TestDocument.pdf")

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 557.69502 > 550.1916858846154.
IsChangePoint: Marked as a change because one of 9/7/2022 12:22:27 PM, 11/30/2022 3:45:04 PM, 12/8/2022 3:49:24 AM falls between 11/29/2022 2:55:01 PM and 12/8/2022 3:49:24 AM.
IsRegressionStdDev: Marked as regression because -330.3355798255706 (T) = (0 -557274718.5647686) / Math.Sqrt((98028916897.25769 / (13)) + (54037767667.19625 / (22))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (22) - 2, .025) and -0.06300191913979473 = (524246201.75260633 - 557274718.5647686) / 524246201.75260633 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: EgorBo
Labels:

area-System.IO.Compression
Milestone: -

@cincuranet
Copy link
Contributor

Probably caused by #79025.

cc @MihaZupan

@cincuranet cincuranet changed the title [Perf] Windows/arm64: 2 Regressions on 11/30/2022 8:56:07 PM Regressions in System.IO.Compression.Brotli Dec 8, 2022
@cincuranet cincuranet added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Dec 8, 2022
@MihaZupan
Copy link
Member

I don't think these benchmarks use Archiving.Utils.Windows.cs/exercise the changed code. I don't believe it's connected to my change.

The benchmark is just calling into BrotliEncoder.TryCompress, which just looks like a wrapper over a P/Invoke to me.

@smasher164 smasher164 removed the untriaged New issue has not been triaged by the area owner label Feb 6, 2023
@smasher164 smasher164 added this to the 8.0.0 milestone Feb 6, 2023
@EgorBo
Copy link
Member

EgorBo commented Mar 27, 2023

No clear suspects from the commit list

@EgorBo EgorBo modified the milestones: 8.0.0, Future Mar 27, 2023
@EgorBo
Copy link
Member

EgorBo commented May 6, 2023

image

Regression is no more

@EgorBo EgorBo closed this as completed May 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-System.IO.Compression tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@EgorBo @cincuranet @smasher164 @MihaZupan