SqlBytes from Stream doesn't work for partial reads

[stephentoub]

Repro:

using System.Data.SqlTypes;

var stream = new TrickleStream(new byte[] { 1, 2, 3, 4, 5 });
var bytes = new SqlBytes(stream);
Console.WriteLine(BitConverter.ToString(bytes.Buffer));

class TrickleStream : MemoryStream
{
    public TrickleStream(byte[] bytes) : base(bytes) { }

    public override int Read(byte[] buffer, int offset, int count) =>
        base.Read(buffer, offset, Math.Min(count, 1));
    public override int Read(Span<byte> buffer) =>
        base.Read(buffer.IsEmpty ? buffer : buffer.Slice(0, 1));
}

That should output:

01-02-03-04-05

but ends up outputting:

01-00-00-00-00

The Stream.Read operations SqlBytes performs assumes Read will always read as much as was requested, which isn't guaranteed:

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 182 in 5a10aa6

_stream.Read(buffer, 0, checked((int)_stream.Length));

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 322 in 5a10aa6

_stream.Read(buffer, offsetInBuffer, count);

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 459 in 5a10aa6

_stream.Read(_rgbBuf, 0, (int)lStreamLen);

cc: @roji, @eerhardt

[ghost]

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro:

using System.Data.SqlTypes;

var stream = new TrickleStream(new byte[] { 1, 2, 3, 4, 5 });
var bytes = new SqlBytes(stream);
Console.WriteLine(BitConverter.ToString(bytes.Buffer));

class TrickleStream : MemoryStream
{
    public TrickleStream(byte[] bytes) : base(bytes) { }

    public override int Read(byte[] buffer, int offset, int count) =>
        base.Read(buffer, offset, Math.Min(count, 1));
    public override int Read(Span<byte> buffer) =>
        base.Read(buffer.IsEmpty ? buffer : buffer.Slice(0, 1));
}

That should output:

01-02-03-04-05

but ends up outputting:

01-00-00-00-00

The Stream.Read operations SqlBytes performs assumes Read will always read as much as was requested, which isn't guaranteed:

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 182 in 5a10aa6

_stream.Read(buffer, 0, checked((int)_stream.Length));

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 322 in 5a10aa6

_stream.Read(buffer, offsetInBuffer, count);

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 459 in 5a10aa6

_stream.Read(_rgbBuf, 0, (int)lStreamLen);

cc: @roji, @eerhardt

Author:	stephentoub
Assignees:	-
Labels:	area-System.Data
Milestone:	-

[stephentoub]

Related:
#69159

[roji]

/cc @David-Engel

[ghost]

Tagging subscribers to this area: @cheenamalhotra, @David-Engel
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro:

using System.Data.SqlTypes;

var stream = new TrickleStream(new byte[] { 1, 2, 3, 4, 5 });
var bytes = new SqlBytes(stream);
Console.WriteLine(BitConverter.ToString(bytes.Buffer));

class TrickleStream : MemoryStream
{
    public TrickleStream(byte[] bytes) : base(bytes) { }

    public override int Read(byte[] buffer, int offset, int count) =>
        base.Read(buffer, offset, Math.Min(count, 1));
    public override int Read(Span<byte> buffer) =>
        base.Read(buffer.IsEmpty ? buffer : buffer.Slice(0, 1));
}

That should output:

01-02-03-04-05

but ends up outputting:

01-00-00-00-00

The Stream.Read operations SqlBytes/SqlChars performs assumes Read will always read as much as was requested, which isn't guaranteed:

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 182 in 5a10aa6

_stream.Read(buffer, 0, checked((int)_stream.Length));

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 322 in 5a10aa6

_stream.Read(buffer, offsetInBuffer, count);

runtime/src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBytes.cs

Line 459 in 5a10aa6

_stream.Read(_rgbBuf, 0, (int)lStreamLen);

cc: @roji, @eerhardt

Author:	stephentoub
Assignees:	-
Labels:	area-System.Data, area-System.Data.SqlClient, untriaged
Milestone:	-