SoundPlayer from Stream doesn't work for partial reads

[stephentoub]

Repro:

using System.Media;

byte[] wav = File.ReadAllBytes(@"C:\Windows\Media\chimes.wav");

var player = new SoundPlayer();
player.Stream = new TrickleStream(wav);
player.PlaySync();

class TrickleStream : MemoryStream
{
    public TrickleStream(byte[] bytes) : base(bytes) { }

    public override int Read(byte[] buffer, int offset, int count) =>
        base.Read(buffer, offset, Math.Min(count, 1));
    public override int Read(Span<byte> buffer) =>
        base.Read(buffer.IsEmpty ? buffer : buffer.Slice(0, 1));
}

That should play a chime but instead crashes with an exception about the audio data's header being invalid. That's because it assumes that Stream.Read will always return as much data as was requested, which is not a valid assumption:

runtime/src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs

Line 313 in 1928cd2

_stream.Read(_streamData, 0, streamLen);

cc: @eerhardt

[stephentoub]

Related:
#69159

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro:

using System.Media;

byte[] wav = File.ReadAllBytes(@"C:\Windows\Media\chimes.wav");

var player = new SoundPlayer();
player.Stream = new TrickleStream(wav);
player.PlaySync();

class TrickleStream : MemoryStream
{
    public TrickleStream(byte[] bytes) : base(bytes) { }

    public override int Read(byte[] buffer, int offset, int count) =>
        base.Read(buffer, offset, Math.Min(count, 1));
    public override int Read(Span<byte> buffer) =>
        base.Read(buffer.IsEmpty ? buffer : buffer.Slice(0, 1));
}

That should play a chime but instead crashes with an exception about the audio data's header being invalid. That's because it assumes that Stream.Read will always return as much data as was requested, which is not a valid assumption:

runtime/src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs

Line 313 in 1928cd2

_stream.Read(_streamData, 0, streamLen);

cc: @eerhardt

Author:	stephentoub
Assignees:	-
Labels:	area-System.IO
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-microsoft-win32
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Repro:

using System.Media;

byte[] wav = File.ReadAllBytes(@"C:\Windows\Media\chimes.wav");

var player = new SoundPlayer();
player.Stream = new TrickleStream(wav);
player.PlaySync();

class TrickleStream : MemoryStream
{
    public TrickleStream(byte[] bytes) : base(bytes) { }

    public override int Read(byte[] buffer, int offset, int count) =>
        base.Read(buffer, offset, Math.Min(count, 1));
    public override int Read(Span<byte> buffer) =>
        base.Read(buffer.IsEmpty ? buffer : buffer.Slice(0, 1));
}

That should play a chime but instead crashes with an exception about the audio data's header being invalid. That's because it assumes that Stream.Read will always return as much data as was requested, which is not a valid assumption:

runtime/src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs

Line 313 in 1928cd2

_stream.Read(_streamData, 0, streamLen);

cc: @eerhardt

Author:	stephentoub
Assignees:	-
Labels:	area-Microsoft.Win32, untriaged
Milestone:	-