Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregate the register iterations based on intType/floatType #83109

Closed
2 tasks done
kunalspathak opened this issue Mar 7, 2023 · 2 comments · Fixed by #85744
Closed
2 tasks done

Segregate the register iterations based on intType/floatType #83109

kunalspathak opened this issue Mar 7, 2023 · 2 comments · Fixed by #85744
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@kunalspathak
Copy link
Member

kunalspathak commented Mar 7, 2023

We noticed in #79544 (comment) and lately in #82731 that we should not iterate over all the register sets (specially do not iterate over float/SIMD if we know that there are no variables in the method). This will improve the TP performance.

Today, at multiple hot places, we iterate over all the registers.

for (regNumber reg = REG_FIRST; reg < ACTUAL_REG_COUNT; reg = REG_NEXT(reg))
{
 ...
}

Some other TP improvement potential:

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 7, 2023
@kunalspathak kunalspathak self-assigned this Mar 7, 2023
@teo-tsirpanis teo-tsirpanis added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 7, 2023
@ghost
Copy link

ghost commented Mar 7, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

We noticed in #79544 (comment) and lately in #82731 that we should not iterate over all the register sets (specially do not iterate over float/SIMD if we know that there are no variables in the method). This will improve the TP performance.

Today, at multiple hot places, we iterate over all the registers.

for (regNumber reg = REG_FIRST; reg < ACTUAL_REG_COUNT; reg = REG_NEXT(reg))
{
 ...
}
Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants