Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][perf] iOS disk size regression on 12 Apr 2023 #85450

Closed
kotlarmilos opened this issue Apr 27, 2023 · 4 comments
Closed

[mono][perf] iOS disk size regression on 12 Apr 2023 #85450

kotlarmilos opened this issue Apr 27, 2023 · 4 comments
Assignees
Labels
area-Codegen-AOT-mono os-ios Apple iOS size-reduction Issues impacting final app size primary for size sensitive workloads tenet-performance Performance related issue
Milestone

Comments

@kotlarmilos
Copy link
Member

kotlarmilos commented Apr 27, 2023

Description

Disk size (SOD) regressions detected in HelloiOS app.

Details - Mono AOT LLVM Release

Date Diff Change Size increase (bytes) Size increase (%)
12 Apr 2022 e7ed417...7526a4c #84289 590688 2.11

Screenshot 2023-04-27 at 10 11 36

Configuration

OS: iPhone 12 Mini
Architecture: arm64
.NET version: 8.0.100-preview.3.23178.7

@kotlarmilos kotlarmilos added tenet-performance Performance related issue area-Codegen-AOT-mono os-ios Apple iOS size-reduction Issues impacting final app size primary for size sensitive workloads labels Apr 27, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Disk size (SOD) regressions detected in HelloiOS app.

Details - Mono AOT LLVM Release

Date Diff Size increase (bytes) Size increase (%)
12 Apr 2022 e7ed417...7526a4c #84289 590688

Screenshot 2023-04-27 at 10 11 36

Configuration

OS: iPhone 12 Mini
Architecture: arm64
.NET version: 8.0.100-preview.3.23178.7

Author: kotlarmilos
Assignees: -
Labels:

tenet-performance, area-Codegen-AOT-mono, os-ios, size-reduction

Milestone: -

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Apr 27, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Apr 27, 2023
@kotlarmilos
Copy link
Member Author

@fanyang-mono Could the regression be caused by the addition of intrinsified methods? We can list binary symbols before and after the change.

@fanyang-mono
Copy link
Member

I can't think of how emitting intrinsics would make the generated code bigger, on the contrary, I would expect it to be smaller. Please list the symbols before and after the change of the chart, and we could take it from there.

@kotlarmilos
Copy link
Member Author

I assumed that intrinsified methods had been added, but the symbol count remained almost unchanged. However, the bundle size has increased by 36kb. Furthermore, after commit 279c65a, the bundle size has increased by an additional 31kb.

However, none of these changes reflect the increase of 500kb, so further investigation is needed. Symbols before and after the change are at helloios-app-bundles.zip.

@kotlarmilos kotlarmilos modified the milestones: 8.0.0, 9.0.0 Jul 13, 2023
@kotlarmilos kotlarmilos modified the milestones: 9.0.0, Future Jul 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-AOT-mono os-ios Apple iOS size-reduction Issues impacting final app size primary for size sensitive workloads tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

3 participants