Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Threading.Tasks.Tests.Perf_AsyncMethods #94479

Closed
performanceautofiler bot opened this issue Nov 7, 2023 · 4 comments
Closed

Regressions in System.Threading.Tasks.Tests.Perf_AsyncMethods #94479

performanceautofiler bot opened this issue Nov 7, 2023 · 4 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 44a5abd54c8c6888cdbb7fac490279fd7ee3334e
Compare 920cd6e2b01d0fbede8882d015329e9b4d448c98
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Threading.Tasks.Tests.Perf_AsyncMethods

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
313.35 ns 336.14 ns 1.07 0.04 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Threading.Tasks.Tests.Perf_AsyncMethods*'

Payloads

Baseline
Compare

System.Threading.Tasks.Tests.Perf_AsyncMethods.Yield

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Nov 7, 2023
@cincuranet cincuranet removed the untriaged New issue has not been triaged by the area owner label Nov 7, 2023
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Nov 7, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 7, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 7, 2023
@cincuranet cincuranet changed the title [Perf] Linux/x64: 1 Regression on 10/30/2023 10:07:51 PM Regressions in System.Threading.Tasks.Tests.Perf_AsyncMethods Nov 7, 2023
@cincuranet cincuranet added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 7, 2023
@cincuranet
Copy link
Contributor

The diff is roughly 44a5abd...848c729. Could #87672 be the reason? cc @kouvel

@kouvel
Copy link
Member

kouvel commented Nov 7, 2023

It seems unlikely to me that #87672 could cause it, the Lock type is not used by anything in coreclr currently and the remaining changes in the PR were only minor changes that don't appear to be perf-related.

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 8, 2023
@ghost
Copy link

ghost commented Nov 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 44a5abd54c8c6888cdbb7fac490279fd7ee3334e
Compare 920cd6e2b01d0fbede8882d015329e9b4d448c98
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Threading.Tasks.Tests.Perf_AsyncMethods

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
313.35 ns 336.14 ns 1.07 0.04 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Threading.Tasks.Tests.Perf_AsyncMethods*'

Payloads

Baseline
Compare

System.Threading.Tasks.Tests.Perf_AsyncMethods.Yield

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

os-linux, tenet-performance, tenet-performance-benchmarks, arch-x64, area-CodeGen-coreclr, untriaged, runtime-coreclr, needs-area-label

Milestone: -

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 9, 2023
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Nov 27, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 27, 2023
@JulieLeeMSFT JulieLeeMSFT removed their assignment Nov 27, 2023
@kunalspathak
Copy link
Member

The overall trend seems to be in noisy range.

image

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

6 participants