-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NativeAOT] Enable EventSource on more tests #95039
Comments
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsLately we have seen a few stress bugs that reproduce only when EventSource is enabled and events are consumed (i.e #94241, #94873) The set of tests that enable EventSource is relatively small though, so even if there is a bug, the repro rate could be one occurrence per few days or longer. If that is possible and is not too expensive in terms of increasing the time that tests take, I'd recommend enabling EventSource on a few more tests. The following tests were known in the past to be relatively "intense" - enough to uncover various stress issues. Perhaps we can do just these?
Any suggestions on what should be added/removed in this set are welcome.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsLately we have seen a few stress bugs that reproduce only when EventSource is enabled and events are consumed (i.e #94241, #94873) The set of tests that enable EventSource is relatively small though, so even if there is a bug, the repro rate could be one occurrence per few days or longer. If that is possible and is not too expensive in terms of increasing the time that tests take, I'd recommend enabling EventSource on a few more tests. The following tests were known in the past to be relatively "intense" - enough to uncover various stress issues. Perhaps we can do just these?
Any suggestions on what should be added/removed in this set are welcome.
|
CC: @LakshanF |
Should we instead have a dedicated pipeline leg that runs everything with EventSource enabled? It might also need to enable some listeners because this would all likely be no-op without listeners (we just compile more code that then never runs). The tests where we currently enable EventSource all have listeners. The tests where we didn't enable EventSource didn't have any listeners as part of the test. |
Lately we have seen a few stress bugs that reproduce only when EventSource is enabled and events are consumed (i.e #94241, #94873)
The set of tests that enable EventSource is relatively small though, so even if there is a bug, the repro rate could be one occurrence per few days or longer.
If that is possible and is not too expensive in terms of increasing the time that tests take, I'd recommend enabling EventSource on a few more tests. The following tests were known in the past to be relatively "intense" - enough to uncover various stress issues. Perhaps we can do just these?
Any suggestions on what should be added/removed in this set are welcome.
The text was updated successfully, but these errors were encountered: