Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cdacreader project in source-build #100807

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

akoeplinger
Copy link
Member

NativeAOT doesn't work in source-build so we need to disable the project there to avoid restore errors. See dotnet/installer#19333 (comment)

NativeAOT doesn't work in source-build so we need to disable the project there to avoid restore errors.
See dotnet/installer#19333 (comment)
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@filipnavara
Copy link
Member

NativeAOT doesn't work in source-build

I was under the impression that it was already fixed in some .NET 9 preview. Am I mistaken?

@akoeplinger
Copy link
Member Author

I think it was a work in progress, or maybe we're not using a new-enough preview yet?

@akoeplinger
Copy link
Member Author

/ba-g unrelated timeout in Build osx-x64 Debug Libraries_CheckedCoreCLR

@filipnavara
Copy link
Member

or maybe we're not using a new-enough preview yet?

Well, if you mean the .NET SDK that gets downloaded then likely not. I thought it doesn't matter for source build though?!

@akoeplinger akoeplinger merged commit 22d1288 into dotnet:main Apr 9, 2024
146 of 150 checks passed
@akoeplinger akoeplinger deleted the fix-cdacreader-sourcebuild branch April 9, 2024 10:47
@ViktorHofer
Copy link
Member

We are using a recent .NET SDK inside the VMR (for both source-only and non-source-only builds): https://github.com/dotnet/installer/blob/12eec080d5008c56731624c6a8fb9fe2960a1ca0/src/SourceBuild/content/global.json#L3

@akoeplinger
Copy link
Member Author

I think it is still missing this work to light it up: dotnet/source-build#1215 (comment)

@elinor-fung
Copy link
Member

@akoeplinger if we switch the cdacreader to using the Microsoft.DotNet.ILCompiler packages based on Versions.props (or live built if possible) per #100782 (comment) instead of the SDK used to build the repo, that should avoid the issue and allow us to re-enable the project, right?

cc @lambdageek

@jkotas
Copy link
Member

jkotas commented Apr 9, 2024

We publish crossgen2 and ilc with native AOT during the build. It was made to work with source build recently: https://github.com/dotnet/runtime/pull/99148/files#diff-24868b0f4c329f4f69a4a8a33b99827d14c82ae59ea4b21c196dd7a3e0b68bdeL13-L14

The same scheme should work for cdacreader. It would be a good idea to use the exact same native AOT version in all places.

@elinor-fung
Copy link
Member

The same scheme should work for cdacreader. It would be a good idea to use the exact same native AOT version in all places.

I have it (locally) using the version from Version.props like ilc does. Spent a chunk of time trying to use the live built one like crossgen2, but that has been a fair bit more complicated - might just go with the version in Version.props at least for now.

@jkotas
Copy link
Member

jkotas commented Apr 10, 2024

I do not think that using live build is worth the troubles. We may want to switch crossgen2 to LKG as well once we get tired of fixing issues in the live build setup.

matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
NativeAOT doesn't work in source-build so we need to disable the project there to avoid restore errors.
See dotnet/installer#19333 (comment)
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants