Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReflectionAccessAnalyzer logic more similar to ILLink/ILC #105956

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Make ReflectionAccessAnalyzer logic more similar to ILLink/ILC #105956

merged 2 commits into from
Aug 6, 2024

Commits on Aug 5, 2024

  1. Don't store diagnostics in DiagnosticContext 

    Instead, report them immediately.
    @sbomer
    sbomer committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ffeb629 View commit details
    Browse the repository at this point in the history

  2. Avoid DiagnosticContext in ReflectionAccessAnalyzer 

    ReflectionAccessAnalyzer will need to be able to produce diagnostics
with differing locations for a single call to
GetReflectionAccessDiagnostics, to support warnings for
DynamicallyAccessedMembers on type.

This matches ReflectionMarker in ILLink and ILC, where
MarkTypeForDynamicallyAccessedMembers takes a MessageOrigin rather
than a DiagnosticContext.
    @sbomer
    sbomer committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    d42e9b7 View commit details
    Browse the repository at this point in the history