[MonoVM] Fix assert on startup with abcrem optimization enabled #108469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the logic in mini_emit_sext_index_reg and OP_BOUNDS_CHECK decomposition. This was already done for LLVM but not for any other target. Instead there was an assert which was hit early on startup when the optimization was enabled (tested on ARM64).
The optimization is not enabled by default but that's separate issue. There are potentially some performance wins to have. For example, the
Burgers
benchmarks in dotnet/performance shows this:Default:
With -O=abcrem: