-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release/8.0] Fix FP state restore on macOS exception forwarding #109579
base: release/8.0-staging
Are you sure you want to change the base?
[Release/8.0] Fix FP state restore on macOS exception forwarding #109579
Conversation
Backport of dotnet#105003, dotnet#109458 and part of dotnet#99255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 8.0.x
It looks like this fix is also needed on .NET 9 + Intel + macOS. From (build log):
Note the |
Right, I've created a backporting PR to 9 for that today. |
Backport of #105003, #109458 and part of #99255
Customer Impact
[x] Customer reported
[ ] Found internally
Original issue: #109423
Attempt to load Java VM into .NET process on macOS x64 always crashes due to a problem in hardware exception forwarding from coreclr's exception handling port to Java's exception handling port (or any other registered one).
Regression
[x] Yes
[ ] No
Regression in .NET 8.0.8 due to a change to fix AVX512 support on macOS for debugging.
Testing
Testing using a repro provided by the customer and coreclr tests
Risk
Low, fixes a buffer overflow, a stack overflow and obviously incorrect floating point context restoration in case of hardware exception in external non-.NET code.