-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define dirent d_type for Solaris based OS #34263
Conversation
With these changes: src/installer/corehost/build.sh -apphostver "5.0.0-dev" -hostver "5.0.0-dev" \
-fxrver "5.0.0-dev" -policyver "5.0.0-dev" -commithash $(git rev-parse HEAD) -gcc succeeds on SmartOS amd64. There is another layer of shared configuration for SunOS, which is based on top of #34211, I will create a separate PR once these are merged. cc @jkotas |
Libraries tests failures are related to #28553. |
Resolved merge conflict and updated title to reflect what PR is doing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion
@jkotas, seems like two CI legs are green on AzDo but GitHub hasn't sync in past two days:
|
On Solaris-like operating systems such as SmartOS,
struct dirent
does not contain a member calledd_type
. Although we have a comment about it:runtime/src/installer/corehost/cli/hostmisc/pal.unix.cpp
Line 837 in 5eda36e
d_type
. This delta definesd_type
'sDT_UNKNOWN
and friends for Solaris._X
is defined in one of the system header, so undef it before#define
:GCC build of installer was broken even on Linux, due to missing dl link in test project. Align it with what we are already using in src projects:
runtime/src/installer/corehost/cli/common.cmake
Line 44 in 5eda36e
Contributes to #4173.