Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Consider debug levels less than zero disabled #40429

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 5, 2020

fixes #40428

@ghost
Copy link

ghost commented Aug 6, 2020

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member Author

lewing commented Aug 6, 2020

linker test failures look similar to #40398

None of the test failures could be caused by the unmanaged wasm only change.

@lewing lewing merged commit 5a3b5f4 into dotnet:master Aug 6, 2020
@BrzVlad
Copy link
Member

BrzVlad commented Aug 6, 2020

Note that -1 is passed both for release, as well when starting with debugging in debug mode. Is this expected ? Do we currently not support debugging at all ?

@lewing
Copy link
Member Author

lewing commented Aug 6, 2020

Debugging works. I remember the details now. We were using -1 as debugging enabled but with no logging so this should be reverted. If the intent is disable disable debugging when running in release mode in VS blazor will need to pass 0 to the load_runtime call.

cc @pranavkm .

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz modified the milestones: 6.0.0, 5.0.0 Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] Blazor apps started from Visual Studio have optimizations disabled, even in Release
5 participants