Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Long Running JSON tests on Checked CoreCLR #45505

Merged
merged 2 commits into from
Dec 3, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Text.Json/tests/JsonDocumentTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ public static void ParseJson_UnseekableStream_BadBOM(string json)
new WrappedMemoryStream(canRead: true, canWrite: false, canSeek: false, data)));
}

[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
safern marked this conversation as resolved.
Show resolved Hide resolved
[Theory]
[MemberData(nameof(BadBOMCases))]
public static Task ParseJson_UnseekableStream_Async_BadBOM(string json)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ public async Task PropertyCacheWithMinInputsLast()
// this options is not the default options instance the tests will not use previously cached metadata.
private JsonSerializerOptions s_options = new JsonSerializerOptions();

[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
[Fact]
public async Task MultipleTypes()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace System.Text.Json.Serialization.Tests
{
public abstract partial class ConstructorTests
{
[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
[Fact]
public async Task ReadSimpleObjectAsync()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ public static async Task InvalidJsonShouldFailAtAnyPosition_Stream(
}
}

[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestData), /* enumeratePayloadTweaks: */ false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/42677", platforms: TestPlatforms.Windows, runtimes: TestRuntimes.Mono)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ private static void AssertDictionaryElements_StringValues(string serialized)
}
}

[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
safern marked this conversation as resolved.
Show resolved Hide resolved
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/39674", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter))]
public static void DictionariesRoundTrip()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public static async Task NullObjectValue()
Assert.Equal("null", value);
}

[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
[Fact]
public static async Task RoundTripAsync()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1809,6 +1809,7 @@ private static void TrailingCommasHelper(ReadOnlySequence<byte> utf8, JsonReader
}
}

[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
[Theory]
[InlineData("{]")]
[InlineData("[}")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3115,6 +3115,7 @@ public void WritingLargestPossibleBase64Bytes(bool formatted, bool skipValidatio
}

// https://github.com/dotnet/runtime/issues/30746
[SkipOnCoreClr("Long running test on Checked mode", RuntimeConfiguration.Checked)]
[Theory]
[InlineData(true, true)]
[InlineData(true, false)]
Expand Down