Change IMarshallingGenerator.AsNativeType to return ManagedTypeInfo instead of TypeSyntax #78195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and not a TypeSyntax. We need to reason about this type for the unmanaged exception handling design, so using a ManagedTypeInfo is preferable. # Conflicts: # src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/Marshallers/NativeThisToManagedThisMarshallerFactory.cs # src/libraries/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/VariableDeclarations.cs
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsChange IMarshallingGenerator.AsNativeType to return a ManagedTypeInfo and not a TypeSyntax. We need to reason about this type for the unmanaged exception handling design, so using a ManagedTypeInfo is preferable. Split off from #77130 for eaiser review
|
ghost
assigned
This was referenced Nov 11, 2022
elinor-fung
approved these changes
Nov 17, 2022
...e.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/MarshallingGenerator.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Nov 17, 2022
...Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/BoolMarshaller.cs
Show resolved
Hide resolved
…erop.SourceGeneration/Marshalling/MarshallingGenerator.cs Co-authored-by: Elinor Fung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change IMarshallingGenerator.AsNativeType to return a ManagedTypeInfo and not a TypeSyntax. We need to reason about this type for the unmanaged exception handling design, so using a ManagedTypeInfo is preferable. Split off from #77130 for eaiser review