Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of simplifications enabled by folding all indirect access to locals #79722

Merged
merged 10 commits into from
Mar 31, 2023
Merged

Take advantage of simplifications enabled by folding all indirect access to locals #79722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3103794
Simplify DefinesLocal
SingleAccretion Nov 30, 2022
90e5f7e
Delete DefinesLocalAddr from VN
SingleAccretion Nov 30, 2022
df2ef26
Simplify fgPerNodeLocalVarLiveness
SingleAccretion Nov 30, 2022
3aafd5b
Simplify fgRemoveDeadStore
SingleAccretion Nov 30, 2022
e7ee1a0
Simplify gtSetEvalOrder
SingleAccretion Nov 30, 2022
ec6a3b3
Simplify optComputeLoopSideEffectsOfBlock
SingleAccretion Nov 30, 2022
801eec4
Bring back some folding in morph
SingleAccretion Nov 30, 2022
9192e07
Delete IsLocalAddrExpr
SingleAccretion Dec 15, 2022
eb0bbb6
Delete DefinesLocalAddr
SingleAccretion Dec 15, 2022
668bacb
Delete IndirTransform::None
SingleAccretion Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3028,7 +3028,7 @@ class Compiler
// Check if this tree is a typeof()
bool gtIsTypeof(GenTree* tree, CORINFO_CLASS_HANDLE* handle = nullptr);

GenTree* gtCallGetDefinedRetBufLclAddr(GenTreeCall* call);
GenTreeLclVarCommon* gtCallGetDefinedRetBufLclAddr(GenTreeCall* call);

//-------------------------------------------------------------------------
// Functions to display the trees
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/gcinfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ GCInfo::WriteBarrierForm GCInfo::gcIsWriteBarrierCandidate(GenTreeStoreInd* stor
//
GCInfo::WriteBarrierForm GCInfo::gcWriteBarrierFormFromTargetAddress(GenTree* tgtAddr)
{
if (tgtAddr->IsLocalAddrExpr() != nullptr)
if (tgtAddr->OperIsLocalAddr())
{
// No need for a GC barrier when writing to a local variable.
return GCInfo::WBF_NoBarrier;
Expand Down
Loading