Delete GT_ADDR
#84147
Merged
Delete GT_ADDR
#84147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThe real work has at this point been done, so this just deletes the oper and its last use as a sentinel. Some Closes #11057. No diffs expected. With one legacy IR construct gone, let's see how much time will it take to delete its Depends on #79722.
|
Closed
SingleAccretion
force-pushed
the
Delete-Addr-Upstream
branch
from
1066eb8 to
ff0b7be
Compare
|
And they said this day would never come... Glad to see this at long last. |
SingleAccretion
force-pushed
the
Delete-Addr-Upstream
branch
from
ff0b7be to
13f5b0a
Compare
|
@dotnet/jit-contrib |
EgorBo
approved these changes
Mar 31, 2023
will leave it open for someone else to take another look
AndyAyersMS
approved these changes
Apr 1, 2023
|
Congrats! 🎉 @SingleAccretion, design docs also mention $ git grep GT_ADDR
docs/design/coreclr/jit/ryujit-overview.md:| [Rationalization](#rationalization) | Flowgraph order changes from `FGOrderTree` to `FGOrderLinear`. All `GT_COMMA`, `GT_ASG` and `GT_ADDR` nodes are transformed. |
docs/design/coreclr/jit/ryujit-overview.md:* Elimination of address nodes (`GT_ADDR`). These are problematic because of the need for parent context to analyze the child.
docs/design/coreclr/jit/ryujit-overview.md: * All `GT_ADDR` nodes are eliminated (e.g. with `GT_LCL_VAR_ADDR`).
docs/design/coreclr/jit/ryujit-tutorial.md: - Eliminate GT_ADDR: Need parent context to analyze child
docs/design/coreclr/jit/ryujit-tutorial.md:We would like to ensure that all data flows are from child to parent. Examples where this is currently violated are in the assignment, or GT_ASG node, where the data flows from the right hand side of the assignment "over" the parent assignment, to the value being defined on the left hand side. Similarly, the child of a GT_ADDR node may appear to be a use or a definition of the value, when instead its address is being taken.
docs/design/coreclr/jit/ryujit-tutorial.md:- All GT_ADDR nodes are eliminated (e.g. with GT_LCL_VAR_ADDR) |
|
Thank you :). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real work has at this point been done, so this just deletes the oper and its last use as a sentinel. No diffs.
Some
TODO-ADDRs in source still remain, but they can be addressed separately.Closes #11057.
With this legacy IR construct gone, let's see how much time will it take to delete its
ASGcousin :).