Commits on Apr 4, 2023

1. Fix FrozenDictionary/Set handling of ValueTuple keys …

   For small collections of comparable value types, we were using an implementation that sorted the keys in order to a) quickly rule out values outside of the known contained range, and b) stop searching when we hit a value that was too small.  However, this can break for some well-known types. In particular, `ValueTuple<...>` implements `IComparable<ValueTuple<...>>`, but it might throw an exception if you actually try to use its `IComparable<>` implementation if any of the `T` types in the tuple are themselves not comparable.  Since we have no good way then to dynamically select an implementation based on whether it implements `IComparable<>`, I've simply removed those checks / calls from the implementation.
   
   Testing this also highlighted that our existing shared set tests don't like being given non-comparable types, as they use SortedSet which itself suffers from effectively the same issue (but there you can choose to not use SortedSet if it doesn't work for your data, and "sort"ing is part of the name).

   

   stephentoub committed Apr 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 7be9785
   • Browse repository at this point

   Copy the full SHA

   7be9785 View commit details

   Browse the repository at this point in the history