-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Enable webcil in Wasm SDK #84977
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
TODO
|
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ConvertDllsToWebCil.cs
Show resolved
Hide resolved
Failures are not related |
This needs a test in WBT. |
.. that does build/publish, and runs the app. There are existing tests that run blazor apps. |
I haven't done hooking Wasm SDK in WBT yet. It would use the pack from official build, which doesn't have the required changes. I haven't even investigated how difficult it would be. We can either test it manually or postpone it to preview5 probably. |
Is this usable with the sdk currently, or are there other PRs to make this usable? |
EDIT: steps to reproduce https://gist.github.com/maraf/a33651a9151fd129f0457e597cd54ee7 |
unified boot is open on sdk now, best case it will have made it through installer in 4-6 hrs dotnet/sdk#31912 |
I think after this installer codeflow PR dotnet/installer#16179 , the aspnetcore bits are in. so WBT should work now if I try this PR, right? |
It requires SDK from dotnet/sdk#31519. Anyway I can show you what needs to be patched. It's much easier that few days before. |
yea ok - if it's simpler to patch now, I'd like to try it. do we need that SDK PR to flow before we can review and merge this runtime PR? Would anything break if we merged this one early? |
It's safe to merge anytime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I primarily looked at the C# code for the task and the .targets stuff. I didn't try a blazor build, but I'll try it later)
After this. I can confirm webcil is working with blazor. I did the usual WBT setup, but also had to edit
and setup a nuget.config to point to my but after all that, @radical is it possible to make it so WBT sets up |
I think he already has the change stacked up and was just waiting for everything to flow. |
WasmEnableWebcil=true