Add DebuggerTypeProxy to ListDictionaryInternal #91355
Conversation
The ListDictionaryInternalDebugView class improves the debug view of ListDictionaryInternal instances which are used to implement the Data property of the Exception class.
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsThe ListDictionaryInternalDebugView class improves the debug view of ListDictionaryInternal instances which are used to implement the Data property of the Exception class. fixes #91254 The old debugger view: The new debugger view:
|
src/libraries/System.Private.CoreLib/src/System/Collections/ListDictionaryInternal.cs
Outdated
Show resolved
Hide resolved
|
CC @JamesNK if want to have a quick look? |
src/libraries/System.Private.CoreLib/src/System/Collections/ListDictionaryInternal.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Collections/ListDictionaryInternal.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Collections/ListDictionaryInternal.cs
Outdated
Show resolved
Hide resolved
|
@arturek could you please address the feedback so we can proceed merging it? |
* members visibility * field name
|
Sorry, I was a little busy. I made some updates and I'll do the rest here or in a separate PR.. |
|
@arturek could you please agree to the license agreement CLA according to https://github.com/microsoft/contributorlicenseagreement? |
|
@microsoft-github-policy-service agree |
|
@arturek looks one more step to sign the CLA. Thanks for your patience. Somehow the following post gets removed after it shows up for a few seconds. CC @dotnet/dnceng
|
Alas, dnceng does not manage the CLI bot. For support, check with the OSPO. It looks like dotnet is running its own instance of Microsoft CLA tool (notice the different bot name in the screen shot). Be sure to follow those instructions for dotnet. (Perhaps there is some conflict between the Microsoft and Dotnet bots that is causing the post to disappear?) |
|
@arturek could you please finish the CLA agreement to proceed merging it? |
|
@tarekgh I don't know how I can do it. I don't see the comment from a license bot anymore, and adding just my agree comment doesn't seem to work. |
|
@arturek did you see my comment #91355 (comment)? need to use @dotnet-policy-service instead @microsoft-github-policy-service to agree to the CLA. |
|
@dotnet-policy-service agree |
|
Thank you, @tarekgh . I haven't noticed that it has a different version. |
|
Thanks @arturek for providing the change and be patient :-) |
ghost
locked as resolved and limited conversation to collaborators
The ListDictionaryInternalDebugView class improves the debug view of ListDictionaryInternal instances which are used to implement the Data property of the Exception class.
fixes #91254
The old debugger view:
The new debugger view:
