Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Compat] Add MSBuild task to run API Compat standalone #18677

Closed
Tracked by #65260
safern opened this issue Jul 1, 2021 · 2 comments · Fixed by #26616
Closed
Tracked by #65260

[API Compat] Add MSBuild task to run API Compat standalone #18677

safern opened this issue Jul 1, 2021 · 2 comments · Fixed by #26616
Assignees
Milestone

Comments

@safern
Copy link
Member

safern commented Jul 1, 2021

We should add the MSBuild Task to the Microsoft.DotNet.Compatibility package.

I have a prototype here which includes targets and props, it also accepts c# source as an input for the left hand side of the comparison: https://github.com/safern/apicompat/tree/main/src/Microsoft.DotNet.ApiCompatibility.Tasks

cc: @ericst @terrajobst @Anipik

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jul 1, 2021
@ericstj ericstj removed the untriaged Request triage from a team member label Jan 25, 2022
@ViktorHofer
Copy link
Member

As mentioned in #23631, it would be great if the new ApiCompat task would support passing in implementation assemblies instead or in addition to implementation directories. The legacy ApiCompat tooling doesn't support that.

@safern
Copy link
Member Author

safern commented Feb 12, 2022

We should prioritize this for .NET 7 so that dotnet/runtime can start its migration to the new API Compat once the rules gap vs the old tooling is filled.

cc: @joperezr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants