-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to enable hang and crash dumps #11666
Conversation
On vstest side this needs to make it into sdk for there parameters to start working. |
@wli3 Looks like the pipeline is failing with the same on master, and in all other PRs that I could see. Is there an issue that tracks this build problem, please? |
This test is testing CSC behavior. It does not test SDK code. The behaivor is also changed due to dotnet/roslyn#42769
This test is testing CSC behavior. It does not test SDK code. The behaivor is also changed due to dotnet/roslyn#42769
</data> | ||
<data name="CmdBlameHangDescription" xml:space="preserve"> | ||
<value>Run the tests in blame mode and enables collecting hang dump when test exceeds the given timeout. Implies --blame-hang.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes dotnet test --help
to print:
--blame-hang Run the tests in blame mode and enables collecting hang dump when test exceeds the given timeout. Implies --blame-hang.
This is self-referential and redundant. Should Implies --blame-hang.
be part of the documentation for CmdBlameHangTimeoutDescription
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a typo, should have been: Implies --blame
--blame is the option that observes which tests are running but does not create any dumps.
Adds options to enable crash and hang dumps from dotnet test commandline without using runsettings.