Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/razor #31822

Merged
merged 3 commits into from
Apr 19, 2023
Merged

[main] Update dependencies from dotnet/razor #31822

merged 3 commits into from
Apr 19, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 15, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/razor

  • Subscription: 5ba65a57-3ed4-48c1-1d9c-08dac299ead7
  • Build: 20230419.1
  • Date Produced: April 19, 2023 2:08:29 PM UTC
  • Commit: f182ffbd63af02071c127b27d2478fd51e69e983
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202304…
53c70e8 
…15.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23206.5 -> To Version 7.0.0-preview.23215.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Apr 15, 2023
@v-wuzhai
Copy link
Member

@dotnet/razor-compiler Could you take a look at the failures here?

@jjonescz
Copy link
Member

That's weird. The error is due to missing DLL Microsoft.AspNetCore.Razor.Utilities.Shared. And indeed, the transport package Microsoft.CodeAnalysis.Razor.Tooling.Internal version 7.0.0-preview.23213.4 contains the DLL, but the next version 7.0.0-preview.23215.1 doesn't. However, I don't see any relevant change in Razor between these versions: dotnet/razor@8f16bb8...2ae218d

@joeloff
Copy link
Member

joeloff commented Apr 18, 2023

However, I don't see any relevant change in Razor between these versions:

Was this from the last ASP.NET build where the package disappeared? The binlog might offer some clues

@jjonescz jjonescz mentioned this pull request Apr 19, 2023
Merged
@jjonescz
Copy link
Member

jjonescz commented Apr 19, 2023 •
edited
Loading

I realized this is from release/dev17.6 of Razor which probably needs backport of my fix: dotnet/razor#8611.

Or should the flow be fixed instead? E.g. to flow main version of Razor here instead of 17.6? Not sure how that's supposed to be.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202304…
b008f9b 
…18.3

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23206.5 -> To Version 7.0.0-preview.23218.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202304…
0c2ba04 
…19.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23206.5 -> To Version 7.0.0-preview.23219.1
@joeloff joeloff merged commit 2cb2c1b into main Apr 19, 2023
@joeloff joeloff deleted the darc-main-25a3e9b6-c403-4df0-a83a-a14137fa6aa6 branch April 19, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

@joeloff joeloff joeloff approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @jjonescz @joeloff @marcpopMSFT