Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making source modifications during build #3664

Open
3 of 5 tasks
MichaelSimons opened this issue Oct 19, 2023 · 1 comment
Open
3 of 5 tasks

Stop making source modifications during build #3664

MichaelSimons opened this issue Oct 19, 2023 · 1 comment
Labels
area-product-experience Improvements in the end-user's product experience Epic Groups multiple user stories. Can be grouped under a theme.

Comments

@MichaelSimons
Copy link
Member

MichaelSimons commented Oct 19, 2023

During the build several source files are modified. E.g. NuGet feeds are injected, the SDK in the global.json is set to a common version, etc. These didn't cause a problem within a tarball environment but now with the VMR, the present a usability issue for developers making changes intended to be submitted as these infra changes should not be committed.

This PR is a tracking issue to address the following issues:

@MichaelSimons MichaelSimons added the area-product-experience Improvements in the end-user's product experience label Oct 19, 2023
@MichaelSimons MichaelSimons moved this from Backlog to Post 8.0 / Pre 9.0 in .NET Source Build Oct 19, 2023
@MichaelSimons MichaelSimons moved this from Post 8.0 / Pre 9.0 to Preview 1 in .NET Source Build Nov 14, 2023
@MichaelSimons MichaelSimons moved this from Preview 1 to In Progress in .NET Source Build Dec 14, 2023
@tkapin tkapin added the Epic Groups multiple user stories. Can be grouped under a theme. label Jan 15, 2024
@MichaelSimons MichaelSimons moved this to In Progress in .NET Unified Build Jan 16, 2024
@tkapin
Copy link
Member

tkapin commented Feb 7, 2024

This is currently paused, might require additional product changers to not modify the global.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-product-experience Improvements in the end-user's product experience Epic Groups multiple user stories. Can be grouped under a theme.
Projects
Status: 10.0
Status: Ready
Development

No branches or pull requests

3 participants