-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VMR] Introduce WindowsDesktop to the VMR #3681
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Just reached out to @MichaelSimons offline. I wonder how to make this work. Do I need to add the following tag to wpf's, windowsdesktop's and sdk's corresponding dependency entry in their Version.Details.xml file?
|
The "sdk" reference is confusing me here as the sdk is already in the VMR. In general you are correct. The SourceBuildTarball is the correct element to use when you want the repo included in the VMR but that repo isn't producing a source-build intermediate. |
Per an offline discussion, I now understand what you meant by sdk. |
Finished. WindowsDesktop is now part of the VMR. |
Describe the Problem
WIndowsDesktop needs to be part of the VMR
Describe the Solution
Introduce the winforms, wpf, and windowsdesktop repos to the VMR.
Additional Context
This is required for Vertical Build
The text was updated successfully, but these errors were encountered: