Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VMR] Introduce WindowsDesktop to the VMR #3681

Closed
Tracked by #3706
mmitche opened this issue Oct 23, 2023 · 6 comments
Closed
Tracked by #3706

[VMR] Introduce WindowsDesktop to the VMR #3681

mmitche opened this issue Oct 23, 2023 · 6 comments
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Oct 23, 2023

Describe the Problem

WIndowsDesktop needs to be part of the VMR

Describe the Solution

Introduce the winforms, wpf, and windowsdesktop repos to the VMR.

Additional Context

This is required for Vertical Build

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member Author

mmitche commented Oct 23, 2023

@ViktorHofer

@ViktorHofer
Copy link
Member

Just reached out to @MichaelSimons offline. I wonder how to make this work.

Do I need to add the following tag to wpf's, windowsdesktop's and sdk's corresponding dependency entry in their Version.Details.xml file?

<SourceBuildTarball RepoName="..." ManagedOnly="true" />

@MichaelSimons
Copy link
Member

Do I need to add the following tag to wpf's, windowsdesktop's and sdk's corresponding dependency entry in their Version.Details.xml file?

The "sdk" reference is confusing me here as the sdk is already in the VMR. In general you are correct. The SourceBuildTarball is the correct element to use when you want the repo included in the VMR but that repo isn't producing a source-build intermediate.

@MichaelSimons
Copy link
Member

Per an offline discussion, I now understand what you meant by sdk.

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 28, 2023

Finished. WindowsDesktop is now part of the VMR.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants