Skip to content

Commit

Permalink
Merge pull request #6340 from dibarbet/forcenoalign
Browse files Browse the repository at this point in the history
Pass ForceNoAlign to ensure msbuild output is parseable by the vscode problem matcher
  • Loading branch information
dibarbet authored Sep 21, 2023
2 parents 67691f8 + 7b53021 commit c2f47ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions omnisharptest/omnisharpFeatureTests/assets.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ suite('Asset generation: csproj', () => {
// We do not check the watch task since this parameter can break hot reload scenarios.
tasksJson.tasks
.filter((task) => task.label !== 'watch')
.forEach((task) => task.args!.should.contain('/consoleloggerparameters:NoSummary'));
.forEach((task) => task.args!.should.contain('/consoleloggerparameters:NoSummary;ForceNoAlign'));
});

test("Generated 'watch' task does not have the property GenerateFullPaths set to true ", () => {
Expand Down Expand Up @@ -111,7 +111,7 @@ suite('Asset generation: csproj', () => {

const watchTask = tasksJson.tasks!.find((task) => task.label === 'watch');
isNotNull(watchTask?.args);
watchTask.args.should.not.contain('/consoleloggerparameters:NoSummary');
watchTask.args.should.not.contain('/consoleloggerparameters:NoSummary;ForceNoAlign');
});

test('Create tasks.json for nested project opened in workspace', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ export class AssetGenerator {
}

commandArgs.push('/property:GenerateFullPaths=true');
commandArgs.push('/consoleloggerparameters:NoSummary');
commandArgs.push('/consoleloggerparameters:NoSummary;ForceNoAlign');
}

private getBuildProjectPath(): string | null {
Expand Down

0 comments on commit c2f47ad

Please sign in to comment.