Skip to content

Commit

Permalink
Merge pull request #6791 from dibarbet/update_roslyn
Browse files Browse the repository at this point in the history
Update Roslyn version to 4.10.0-1.24058.1
  • Loading branch information
arunchndr authored Jan 9, 2024
2 parents 94c2e72 + 9cc41f6 commit f5fb753
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 8 deletions.
13 changes: 12 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,24 @@
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)

## Latest
* Update Roslyn to 4.10.0-1.24058.1 (PR: [#6791](https://github.com/dotnet/vscode-csharp/pull/6791))
* Fix error when a source generated file was present in find references or go to definition requests (PR: [#71395](https://github.com/dotnet/roslyn/pull/71395))
* Remove usages of incorrectly licensed library (Microsoft.VisualStudio.LanguageServer.Protocol) for serialization of LSP json messages (PR: [#68990](https://github.com/dotnet/roslyn/pull/68990))
* Add custom Roslyn serialization code for LSP json messages (PR: [#71141](https://github.com/dotnet/roslyn/pull/71141))
* Use named executables for the language server process on Windows and Linux (PR: [#71007](https://github.com/dotnet/roslyn/pull/71007))
* Add back LSP request telemetry in CLaSP queue (PR: [#71157](https://github.com/dotnet/roslyn/pull/71157))
* Fix command enablement by using specific activation contexts for O#, Roslyn standalone, and Roslyn devkit (PR: [#6782](https://github.com/dotnet/vscode-csharp/pull/6782))
* Update Razor to 7.0.0-preview.23627.2 (PR: [#6770](https://github.com/dotnet/vscode-csharp/pull/6770)
* Fixed issue where Razor trace level was ignored. New `razor.server.trace` setting created that is not ignored (PR: [dotnet/razor#9745](https://github.com/dotnet/razor/pull/9745))
* Update Roslyn to 4.9.0-3.23611.3 (PR: [#6736](https://github.com/dotnet/vscode-csharp/pull/6736))
* Update OmniSharp to 1.39.11 (PR: [#6771](https://github.com/dotnet/vscode-csharp/pull/6771))
* Fix loading AspNetCore projects by shipping the AspNetCore EA library
* Update SDKs and dependencies ([omnisharp-roslyn/#2586](https://github.com/OmniSharp/omnisharp-roslyn/issues/2586), PR: [omnisharp-roslyn/#2588](https://github.com/OmniSharp/omnisharp-roslyn/pull/2588))
* Updated to latest dotnet-script 1.5.0 (PR: [omnisharp-roslyn/#2585](https://github.com/OmniSharp/omnisharp-roslyn/pull/2585))
* Update checkForDevCert aka.ms link (PR: [#6769](https://github.com/dotnet/vscode-csharp/pull/6769))
* Support debug apps running under mono runtime using vsdbg (PR: [#6752](https://github.com/dotnet/vscode-csharp/pull/6752))
* Update debugger to 2.9.1 (PR: [#6765](https://github.com/dotnet/vscode-csharp/pull/6765))
* Remove check for projectPath for resolveDebugConfiguration (PR: [#6754](https://github.com/dotnet/vscode-csharp/pull/6754))

## 2.14.8
* Fix Remote Process Listing from Windows (PR: [#6730](https://github.com/dotnet/vscode-csharp/pull/6730))
* Fix description of debugger `console` setting (PR: [#6726](https://github.com/dotnet/vscode-csharp/pull/6726))
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
}
},
"defaults": {
"roslyn": "4.9.0-3.23611.3",
"roslyn": "4.10.0-1.24058.1",
"omniSharp": "1.39.11",
"razor": "7.0.0-preview.23627.2",
"razorOmnisharp": "7.0.0-preview.23363.1",
Expand Down
4 changes: 2 additions & 2 deletions src/lsptoolshost/restore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
RestoreParams,
RestorePartialResult,
RestoreRequest,
ProjectHasUnresolvedDependenciesRequest,
ProjectNeedsRestoreRequest,
} from './roslynProtocol';
import path = require('path');

Expand All @@ -32,7 +32,7 @@ export function registerRestoreCommands(
})
);

languageServer.registerOnRequest(ProjectHasUnresolvedDependenciesRequest.type, async (params) => {
languageServer.registerOnRequest(ProjectNeedsRestoreRequest.type, async (params) => {
await restore(languageServer, restoreChannel, params.projectFilePaths, false);
});
}
Expand Down
8 changes: 4 additions & 4 deletions src/lsptoolshost/roslynProtocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export interface RestorePartialResult {
message: string;
}

export interface UnresolvedProjectDependenciesParams {
export interface ProjectNeedsRestoreName {
/**
* The set of projects that have unresolved dependencies and require a restore.
*/
Expand Down Expand Up @@ -268,8 +268,8 @@ export namespace RestorableProjects {
export const type = new lsp.RequestType0<string[], void>(method);
}

export namespace ProjectHasUnresolvedDependenciesRequest {
export const method = 'workspace/_roslyn_projectHasUnresolvedDependencies';
export namespace ProjectNeedsRestoreRequest {
export const method = 'workspace/_roslyn_projectNeedsRestore';
export const messageDirection: lsp.MessageDirection = lsp.MessageDirection.serverToClient;
export const type = new lsp.RequestType<UnresolvedProjectDependenciesParams, void, void>(method);
export const type = new lsp.RequestType<ProjectNeedsRestoreName, void, void>(method);
}

0 comments on commit f5fb753

Please sign in to comment.