Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jsonc-parser for parsing JSON #1237

Closed
DustinCampbell opened this issue Feb 13, 2017 · 2 comments
Closed

Use jsonc-parser for parsing JSON #1237

DustinCampbell opened this issue Feb 13, 2017 · 2 comments
Labels
Improvement OmniSharp

Comments

@DustinCampbell
Copy link
Member

This is the JSON scanner that is used in VS Code for parsing JSON files that include comments. We should use that instead of our home-rolled scanner.
@DustinCampbell
Copy link
Member Author

We should also remove the json.tolerantParse(...) API in favor of this. (#1076)

@DustinCampbell DustinCampbell mentioned this issue Jun 14, 2018
Closed
This was referenced Sep 16, 2021
Open
Open
Open
@JoeRobich
Copy link
Member

Closing as it seems the jsonc-parser was adopted at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement OmniSharp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DustinCampbell @jasonmalinowski @JoeRobich