Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Canceled #148

Closed
aeschli opened this issue Apr 6, 2016 · 6 comments
Closed

Error: Canceled #148

aeschli opened this issue Apr 6, 2016 · 6 comments

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 6, 2016

Error reported by error telemetry

~3000 occurrences:
Error: Canceled
at /Users/aioutecism/.vscode-insiders/extensions/ms-vscode.csharp-0.3.7/out/omnisharpServer.js:235:31
/vs/base/common/callbackList.ts#63:26 (apply)
/vs/base/common/event.ts#107:26 (call)
/vs/base/common/cancellation.ts#42:18 (fire)
/vs/base/common/cancellation.ts#83:31 (cancel)
at DiagnosticsProvider._validateProject (/Users/aioutecism/.vscode-insiders/extensions/ms-vscode.csharp-0.3.7/out/features/diagnosticsProvider.js:149:37)
at DiagnosticsProvider._onDocumentAddOrChange (/Users/aioutecism/.vscode-insiders/extensions/ms-vscode.csharp-0.3.7/out/features/diagnosticsProvider.js:102:18)

@DustinCampbell
Copy link
Member

@aeschli, I'm not sure what to do with this issue. If I understand the issue. It is due to a cancellation token being cancelled, which should be expected. Why is telemetry being triggered for cancellation? That seems like a normal operation that telemetry shouldn't capture.

@aeschli
Copy link
Contributor Author

aeschli commented Apr 19, 2016

@jrieken Joh, any ideas?

@jrieken
Copy link
Contributor

jrieken commented Apr 19, 2016

I'd guess this is because a rejected promise isn't handled and ends up in our unhandled rejection handler.

@DustinCampbell
Copy link
Member

Ah ha! So, it was your fault @jrieken. 😄

I'll take a look.

@jrieken
Copy link
Contributor

jrieken commented Apr 20, 2016

Dude - all of this is my fault 🙈 Code written timely before a release in the middle of the night

@rchande
Copy link

rchande commented Jun 6, 2018

@aeschli @jrieken It doesn't look like we have code that spews that particular message any more. I'm going to close this issue. Feel free to reopen/comment if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants