Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias .NET Restore... commands to dotnet restore... #2931

Closed
spboyer opened this issue Mar 21, 2019 · 5 comments
Closed

Alias .NET Restore... commands to dotnet restore... #2931

spboyer opened this issue Mar 21, 2019 · 5 comments

Comments

@spboyer
Copy link

spboyer commented Mar 21, 2019

Currently .NET commands are only surfaced in the command pallete when .NET is typed. Typing dotnet should also surface the core commands for .NET Core.

cc:/ @timheuer

@rchande
Copy link

rchande commented Mar 21, 2019

@spboyer It's not the intention of the C# extension to expose dotnet.exe through the command palette.

We offer commands for performing restore on a specific project, or on all projects we can see. We could potentially alias them with a version that starts with "dotnet".

We offer a separate command to generate VS Code tasks/launch assets, but that doesn't really relate to any feature of dotnet.exe.

@spboyer
Copy link
Author

spboyer commented Mar 21, 2019

Offering only restore appears incomplete knowing there are other operations we would inherently perform on .NET projects we could see.

Not looking to expose all functionality of the dotnet.exe however perhaps this extension should instead of a one off wrapping the exe itself and duplicating some of the operations here?

The intent of the issue was to alias “dotnet” when typed to surface the existing options prefaced with or containing “.NET”

@rchande rchande changed the title Ability to type dotnet and get .NET commands Alias .NET Restore... commands to dotnet restore... Mar 21, 2019
@rchande
Copy link

rchande commented Mar 21, 2019

@spboyer

The intent of the issue was to alias “dotnet” when typed to surface the existing options prefaced with or containing “.NET”

Great! We're on the same page here. Let's use this issue to track that.

Offering only restore appears incomplete

We've exposed a bunch of functionality in a way that's more idiomatic to VS Code. For example, if you use the command .NET: Generate Assets for Build and Debug, we generate the appropriate VS Code configuration to wire up the VS Code Build and Run commands, which may shell out to dotnet.exe. This obviously gives you the equivalent to dotnet build and dotnet run. We offer restore as a named command because it doesn't map onto a VS Code concept by itself, and you might want to restore without building (if you changed a project file).

@timheuer actually recently updated our tasks generation to add publish and I think that's probably a better way to go than adding individual aliased commands (#2903). What do you think?

@spboyer
Copy link
Author

spboyer commented Mar 21, 2019

Agreed on all points here.

@JoeRobich
Copy link
Member

Closing due to lack of activity.

@JoeRobich JoeRobich closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants