Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold All Regions no longer works with new language server #6234

Closed
zeroskyx opened this issue Aug 26, 2023 · 1 comment · Fixed by dotnet/roslyn#69817
Closed

Fold All Regions no longer works with new language server #6234

zeroskyx opened this issue Aug 26, 2023 · 1 comment · Fixed by dotnet/roslyn#69817
Assignees
Milestone

Comments

@zeroskyx
Copy link

Type: Bug

Issue Description

Using the Fold All Regions command does not collapse regions (it just does nothing).

Steps to Reproduce

  1. Add code regions (#region This is a region and #endregion) in a C# document
  2. Execute the command Fold All Regions

Expected Behavior

The region This is a region is collapsed.

Actual Behavior

Nothing happens.

Logs

C# log

Post the output from Output-->C# here

C# LSP Trace Logs

Post the output from Output-->C# LSP Trace Logs here. Requires `dotnet.server.trace` to be set to `Trace`

Environment information

VSCode version: 1.81.1
C# Extension: 2.0.413
Using OmniSharp: false

Dotnet Information .NET SDK: Version: 7.0.306 Commit: f500069cb7

Runtime Environment:
OS Name: manjaro
OS Version:
OS Platform: Linux
RID: manjaro-x64
Base Path: /home/zeroskyx/Apps/dotnet/sdk/7.0.306/

Host:
Version: 7.0.9
Architecture: x64
Commit: 8e9a17b221

.NET SDKs installed:
7.0.306 [/home/zeroskyx/Apps/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 7.0.9 [/home/zeroskyx/Apps/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 7.0.9 [/home/zeroskyx/Apps/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
None

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

Visual Studio Code Extensions
Extension Author Version Folder Name
code-spell-checker streetsidesoftware 2.20.5 streetsidesoftware.code-spell-checker-2.20.5
code-spell-checker-german streetsidesoftware 2.2.1 streetsidesoftware.code-spell-checker-german-2.2.1
csharp ms-dotnettools 2.0.413 ms-dotnettools.csharp-2.0.413-linux-x64
docomment k--kato 1.0.0 k--kato.docomment-1.0.0
hexeditor ms-vscode 1.9.12 ms-vscode.hexeditor-1.9.12
rainbow-csv mechatroner 3.7.0 mechatroner.rainbow-csv-3.7.0
vscode-dotnet-runtime ms-dotnettools 1.7.1 ms-dotnettools.vscode-dotnet-runtime-1.7.1
vscode-guid heaths 1.7.0 heaths.vscode-guid-1.7.0
vscode-print pdconsec 0.11.15 pdconsec.vscode-print-0.11.15
vscode-todo-highlight wayou 1.0.5 wayou.vscode-todo-highlight-1.0.5

Extension version: 2.0.413
VS Code version: Code 1.81.1 (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:18:39.991Z)
OS version: Linux x64 6.4.9-1-MANJARO
Modes:

System Info
Item Value
CPUs 12th Gen Intel(R) Core(TM) i7-1265U (12 x 4297)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 2, 2, 2
Memory (System) 31.06GB (22.34GB free)
Process Argv --unity-launch /home/zeroskyx/skyseract/Libraries/skyseract.Hosting
Screen Reader no
VM 0%
DESKTOP_SESSION gnome
XDG_CURRENT_DESKTOP GNOME
XDG_SESSION_DESKTOP gnome
XDG_SESSION_TYPE wayland
@dibarbet
Copy link
Member

We probably just have the wrong classification for some of our folding regions - first place to debug is here - https://sourceroslyn.io/#Microsoft.CodeAnalysis.LanguageServer.Protocol/Handler/FoldingRanges/FoldingRangesHandler.cs,89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants