Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tooltips appear on top of each other during code completion #6501

Closed
aradalvand opened this issue Oct 6, 2023 · 6 comments · Fixed by #7446
Closed

Two tooltips appear on top of each other during code completion #6501

aradalvand opened this issue Oct 6, 2023 · 6 comments · Fixed by #7446
Assignees
Milestone

Comments

@aradalvand
Copy link

aradalvand commented Oct 6, 2023

See the following video — when you type the opening parenthesis after the .Add method, previously you'd just see the method arguments in the code completion tooltip as expected, but now another useless/irrelevant window appears on top of that and covers it, so you have to press Esc to get rid of it. This happens constantly and is extremely annoying.

Untitled.Project.mp4

Environment data

VS Code version: 1.83.0 — e7e037083ff4455cf320e344325dacb480062c3c
C# Extension version: v2.5.30

@arunchndr arunchndr added this to the October milestone Oct 9, 2023
@dibarbet
Copy link
Member

Note - this is due to the location of the code and window size. The signature help window is supposed to appear above the line, while the completion list appears below. However if there is not enough space in the text editor window above, they will appear overlapped.

This behavior is defined by VSCode. The most we could do on the extension side is have an option to disable completion in argument lists, which I'm not sure we want to do.

@aradalvand
Copy link
Author

aradalvand commented Oct 10, 2023

@dibarbet The argument list is the one that should be shown. The other one should NOT be shown in this context, just like how it wasn't previously.
v1.x literally worked perfectly in this regard. Why couldn't it just do the same thing it used to do?!

@aradalvand
Copy link
Author

This is what it looks like in v1.26.0:

Untitled.Project.mp4

@DovydasNavickas
Copy link

This is still happening. No matter of the code location and where they're rendered, unless completion you need is for AbandonedMutexException or something else that is at the start of the alphabet, the completion is rarely what I want. I press Esc to get rid of it 100% of the time, which is annoying.
And after getting rid of the completion, typing a character gives completion again, which is when I want the completion to happen so only opening the parenthesis is where completion should not be shown.
The signature help window is what I expect to see and if there are overloads, I expect to be able to cycle through them with up/down arrows. This works only after Esc(aping) the completion window.

Are we he minority here with @aradalvand and think this behavior is counterproductive? 😄 If so, is there a setting for this that I didn't find?

@dibarbet
Copy link
Member

Option dotnet.completion.triggerCompletionInArgumentLists to disable completion in argument lists added in #7446.

This is not released yet, but should be part of next weeks prerelease update. Will post here once it is available.

@dibarbet
Copy link
Member

This is available in 2.45.17 prerelease. Unchecking dotnet.completion.triggerCompletionInArgumentLists will prevent the completion list from showing up in argument list contexts (you will only see signature help).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants