-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omnisharp crashes on fedora 23 #773
Comments
I get some problem with debian 9 after a update yesterday |
@msmaldi in what way are they similar to the problem I reported? |
@DustinCampbell I tried a minimal
|
I did a build and publish of omnisharp-roslyn dev. The resulting OmniSharp also crashes.
Attaching the debugger to the OmniSharp shows I don't think any of the above are pointing the reason of the crash. |
Yeah, those errors are red herrings. I've just gotten a Fedora 23 VM set up and will let you know if I can repro. You might consider just using the mono-based OmniSharp to unblock yourself. I wrote up some instructions in #775 here: #775 (comment). |
Here it reproduces almost instantly when making some edits in the code. I notice OmniSharp has crashed when intellisense stops working. In case it doesn't repro on your VM, try increasing the number of cores. The dmesg traps often contain pthreads so the issue may be related to multithreading. |
Here some stacktrace+threads of two crashes.
|
@DustinCampbell not sure whether you had time to look at this issue further. Were you able to reproduce the problem? Would you like a coredump? Do you see something noteworthy in the stacktraces? Does this look like an OmniSharp issue or is it more 'low level' corefx/coreclr? |
The issue looks much lower level that OmniSharp itself. I'm quite certain that this used to work on Fedora 23 and it worked for me when I tried it in a VM. Do you have any idea whether there have been updates to Fedora 23? (other than Fedora 24 of course 😄) |
I am not aware of any updates to fedora 23. My system is a clean fedora 23 workstation netinstall. I created a matching issue in the coreclr repo. |
I will close this issue here. The root cause is coreclr crashing on >= 4.6 kernels. See https://github.com/dotnet/coreclr/issues/7345. |
FWIW, |
@omajid yes indeed, see referenced issue |
We'll need to get OmniSharp moved over to .NET Core 1.0.1 and then update the extension to use a new build of it. I'll take a look at it this morning. |
@DustinCampbell also see the referenced issue, it seems .NET core 1.0.1 does not include the fix (alltough that was the intent) |
Ah -- thanks! I hadn't looked at it thoroughly. |
I'll keep this issue open until that gets fixed. This will require a new build of OmniSharp to pick up the CoreCLR fix. Were you able to use the Mono-based OmniSharp to unblock yourself? |
The issue causes all dotnet programs to crash randomly. Per https://github.com/dotnet/coreclr/issues/6016#issuecomment-228889613 I |
Even programs running on Mono? |
Mono is not affected. I am developping a dotnet app. If I run omnisharp on mono, omnisharp won't crash, but my app will (unless I also target mono). Easiest fix is setting the envvar. |
Got it. Makes sense. Thanks for helping me understand the root cause. |
It looks like this will fix the issue after all. |
Unless it takes a Preview 3 build of .NET Core SDK. 😄 |
There is a new beta of the C# extension available here that should address this problem. Feel free to try it out and let me know if it address the issue for you. |
Environment data
dotnet --info
output:VS Code version:
1.5.2
C# Extension version:
1.4.1
Steps to reproduce
Open .NET Core project with project.json
Expected behavior
Intellisense should be working
Actual behavior
Intellisense is not working.
The
omnisharp log
output shows omnisharp is starting:Intellisense is not working.
dmesg
shows omnisharp has crashed.Restarting omnisharp in vscode makes intellisense work for a split second until OmniSharp crashes again.
The text was updated successfully, but these errors were encountered: