Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Unity auto complete hints are wrong #97

Closed
jrieken opened this issue Mar 16, 2016 · 13 comments
Closed

C# Unity auto complete hints are wrong #97

jrieken opened this issue Mar 16, 2016 · 13 comments

Comments

@jrieken
Copy link
Contributor

jrieken commented Mar 16, 2016

From @zeyangl on March 16, 2016 9:35

  • VSCode Version: 0.10.11
  • OS Version: 10.11

Steps to Reproduce:

  1. As shown in the following image, the autocompletion hints are wrong. It shows raw xml instead of formatted method information.

image

Copied from original issue: microsoft/vscode#4295

@DustinCampbell
Copy link
Member

This should be fixed with the latest release, v1.3.0

@zeyangl
Copy link

zeyangl commented Jul 21, 2016

@DustinCampbell I drag-and-dropped this into VSCode plugin folder. It appears installed in the VSCode extensions panel, with correct version number(1.3.0), but autocomplete does not work. Reverting back to OmniSharp legacy plugin makes autocomplete functional. Please let me know if I did something wrong. I'm really looking forward to the new version as the legacy one seems pretty slow when doing autocompletion.

My env:
VSCode 1.3.1
OS Version: 10.11
Mono: 4.4.1 (mono-4.4.0-branch-c7sr0/4747417 Mon Jun 20 15:43:48 EDT 2016)

@DustinCampbell
Copy link
Member

  1. Did you uninstall the Legacy C# extension before installing the new C# extension? They won't function properly together.
  2. With the C# extension v1.3.0 installed, open your project. Then, select View->Output from the menu and choose OmniSharp Log from the combobox in the upper-right corner of the Output window. Could you copy and paste the log here?

@zeyangl
Copy link

zeyangl commented Jul 21, 2016

  1. Yes I did uninstall the legacy version.
  2. There is no "OmniSharp Log" option in the combobox, only "git", "extensions", and "tasks". I guess maybe the plugin is not running after all? But it does appear installed though.

image

@DustinCampbell
Copy link
Member

That's really strange! It's like the extension isn't activating at all. If you press F1 to bring up the command palette, is the a "Restart OmniSharp" command?

@zeyangl
Copy link

zeyangl commented Jul 21, 2016

As follows:
image

Is there anything else I need to do, other than coping the src to the .vscode/extensions directory?

@DustinCampbell
Copy link
Member

Also, you mentioned dragging and dropping the extension to the plugin folder? I've never tried installing an extension that way. Instead, I open the VSIX with File->Open File in VS Code and the restart VS Code for good measure.

@DustinCampbell
Copy link
Member

oh, yes. You should definitely install it as I suggested. I have no idea how VS Code responds to just copying bits to the extensions folder. I suspect VS Code never scanned the package.json in the extension completely, so you are in a half-installed state.

@zeyangl
Copy link

zeyangl commented Jul 21, 2016

Okay I did what you said, and it seems to installed properly now. Sorry for wasting your time like that, as I didn't find anything about opening .vslx

Another problem shows up. It prompts about installing .Net CLI tools, and when I click yes, it takes me to .Net core webpage. I thought the new version would automatically use Mono. So I should keep both Mono and .Net core stuff for this to work properly? I don't have a problem with this as long as it what it takes to get the new version working. Just want to confirm.

@DustinCampbell
Copy link
Member

Excellent! I'm so glad you were able to get it installed. The prompt is because the .NET CLI tools are required to install the CoreCLR debugger, which you clearly won't be using for Unity development. @gregg-miskelly, do you have any thoughts about this?

@DustinCampbell
Copy link
Member

FWIW, installing the .NET CLI will make the prompt go away. However, I think it might be a bit of an oversight that the extension doesn't provide a way to turn the prompt off.

@zeyangl
Copy link

zeyangl commented Jul 21, 2016

Okay omnisharp is working fine now. I didnt notice the background downloading after installed. That took a couple minutes but everything seems to work fine now. Thanks for the prompt replies. Really helpful.

@gregg-miskelly
Copy link
Contributor

I opened #603 to track trying to improve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants