Autocomplete outputs error to the OmniSharp log

[anfomin]

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.0-preview2-1-003177)

Product Information:
 Version:            1.0.0-preview2-1-003177
 Commit SHA-1 hash:  a2df9c2576

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.11-x64

VS Code version: 1.7.1
C# Extension version: 1.5.3

Steps to reproduce

1. Create empty C# project running .NET Standard 1.6.
2. Create C# class.
3. Show autocomplete.

Expected behavior

There should be no errors in output.

Actual behavior

Omnisharp log shows error for each autocomplete:

[ERROR:Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware] An unhandled exception has occurred: Object reference not set to an instance of an object
[INFORMATION:OmniSharp.Middleware.LoggingMiddleware] /autocomplete: 500 36ms

[DustinCampbell]

Hi! Could you clarify the repro steps a bit? How did you create the empty C# project? Did you use dotnet new?

[anfomin]

@DustinCampbell I've created project via custom project.json and dotnet restore after:

{
	"version": "1.0.0-*",

	"dependencies": {
		"Microsoft.AspNetCore.Mvc.Core": "1.1.0"
	},

	"frameworks": {
		"net46": { },
		"netstandard1.6": { }
	}
}

I've investigated. This exception occurs when autocompletion tries to find completion for variable name. For example, I'm entering: Exception e. When I enter e then exception is logged:

[DustinCampbell]

Thanks for the detailed repro. I'll take a look.

[DustinCampbell]

OK. I have a PR out to omnisharp-roslyn to fix this issue. FWIW, the behavior should be mostly benign. The completion is the same whether the exception is thrown or not.

[anfomin]

I see that completion works but any exception in the log warns. Thanks.

[DustinCampbell]

I've created a v1.6-beta2 release of the C# extension that contains this fix, among others. See this page for information on installing beta releases