-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in configuration snippets #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
package.json
Outdated
"type": "coreclr", | ||
"request": "launch", | ||
"preLaunchTask": "build", | ||
"program": "^\"\\${workspaceRoot}/bin/Debug/<target-framework>/<project-name.dll>\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use their syntax to have the user fill in this path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ex:
"program": "^\"\\${workspaceRoot}/bin/Debug/${1:<target-framework>/<project-name.dll>}\"",
package.json
Outdated
@@ -1131,6 +1131,104 @@ | |||
} | |||
} | |||
}, | |||
"configurationSnippets": [ | |||
{ | |||
"label": ".NET: Launch .NET Core App", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put 'Console' in the title?
package.json
Outdated
"console": "internalConsole", | ||
"pipeTransport": { | ||
"pipeCwd": "^\"\\${workspaceRoot}\"", | ||
"pipeProgram": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'pipeProgram' also?
@gregg-miskelly After looking deep into the vscode source.... You can add comments to the snippets. Instead of using the "body" keyword, use "bodyText". Should we change to that and include comments in our snippets? |
@WardenGnaw unless it is a huge amount of work, I think so. |
bodyText will be used once snippets can call commands, so we can reuse the configurations in assets. |
#1024
Creating snippets for local launch, local attach, local web launch, remote launch and remote attach.