Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be sure to exit from resolved promise deleteIfExists(...) helper #1417

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Be sure to exit from resolved promise deleteIfExists(...) helper #1417

merged 1 commit into from
Apr 21, 2017

Commits on Apr 21, 2017

  1. Be sure to exit from resolved promise deleteIfExists(...) helper 

    Failing to exit when the specified file path doens't exist means that we try to delete that file even though it doesn't exist. This results in a timing issue because the deletion is asynchronous. Essentially, it might unintentionally delete the file springs into being before the promise is resolved.
    @DustinCampbell
    DustinCampbell committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    0946223 View commit details
    Browse the repository at this point in the history