Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test debugging post October VSCode breaking change #1800

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

gregg-miskelly
Copy link
Contributor

This checkin changes the C# extension so that unit test debugging will still work once the vscode.StartDebug command is removed.

To do this I changed our package.json so that we require the 1.15 (July) release of VS Code, and switched to using the new API.

This fixes #1787

This checkin changes the C# extension so that unit test debugging will still work once the `vscode.StartDebug` command is removed.

To do this I changed our package.json so that we require the 1.15 (July) release of VS Code, and switched to using the new API.
Copy link
Contributor

@WardenGnaw WardenGnaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very glad to see this old hack go away

@gregg-miskelly gregg-miskelly merged commit 0e17bc1 into dotnet:master Oct 24, 2017
@gregg-miskelly gregg-miskelly deleted the UnitTestOctoberBreak branch October 24, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Unit Test debugging in October VS Code
4 participants