Update with latest OmniSharp and pick correct version for current Linux distribution #188
Conversation
…ux distribution We've updated OmniSharp to build releases for each Linux distribution that we currently support: CentOS, Debian, Red Hat (RHEL), and Ubuntu. This change adds code to sniff out which of the supported Linux distros we're running on to determine which flavor of OmniSharp we need to download and install.
|
👍 |
|
Note, I may rebase this against 'dev' and resubmit if we think this is important enough to reset Escrow for RC 2. |
|
👍 |
1 similar comment
|
👍 |
|
LGTM |
|
Should there be a default when we hit the none case? I'm thinking of other distros like Arch, this would would then make @markrendle cry if vscode broke for him. Perhaps at that point prompt the user to select the most compatible distro? I know many are debian based, including ubuntu. Perhaps that's a good default. |
|
@david-driscoll -- good suggestion. How do others feel? Would Debian or Ubuntu be a good fallback if the user is on a different distro than one of the "blessed four"? It's likely that OmniSharp may work in those cases, and if not, OmniSharp will simply fail to start. |
|
I don't know that the chances that it would actually work are terribly high -- coreclr is extremely picky. Could a user download there own and set the omnisharp path? If so, that would be my recommendation. |
|
@gregg-miskelly, yes, that's how others would use it. Essentially, they could download the Mono version and be certain of having it work. |
|
Should we spit something to the output window telling them how to do that? |
|
Possibly -- threading that through is a bit tricky because the omnisharpDownload.ts module is used by Gulp as well, which can't have a dependency on VSCode. Let me take a look. |
|
Optional call back delegate? |
|
No, I can put this elsewhere. |
…c to the current Linux distribution can't be found
DustinCampbell
force-pushed
the
update-omnisharp
branch
from
0e2232f
to
e230b12
Compare
|
OK, I added a commit that provides instructions to the user if we fail to find a version of OmniSharp that targets the current Linux distribution. Thoughts? |
| output.appendLine("OmniSharp provides a richer C# editing experience, with features like IntelliSense and Find All References."); | ||
| output.appendLine("It is recommend that you download the version of OmniSharp that runs on Mono using the following steps:"); | ||
| output.appendLine(" 1. If it's not already installed, download and install Mono (http://www.mono-project.com)"); | ||
| output.appendLine(" 2. Download and untar https://github.com/OmniSharp/omnisharp-roslyn/releases/download/v1.9-alpha13/omnisharp-linux-mono.tar.gz"); |
There was a problem hiding this comment.
I'll file an issue to make this a bit more robust for RTM. We don't want to have to update this URL everytime we release.
|
LGTM |
|
Hi @DustinCampbell, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
We have sign off from shiproom as well. |
We've updated OmniSharp to build releases for each Linux distribution that we currently support: CentOS, Debian, Red Hat (RHEL), and Ubuntu. This change adds code to sniff out which of the supported Linux distros we're running on to determine which flavor of OmniSharp we need to download and install.
cc @gregg-miskelly, @chuckries, @caslan, @Pilchie, @david-driscoll