Parse envFile and pass to debugger #1951

SebastianPfliegel · 2018-01-04T22:25:13Z

Closes #1944. Adds a new option for launch.json - envFile: it will read environment variables from the given UTF8 file. This way environment variables can be passed to the debugger and launch.json stays clean of sensitive data (like passwords).

WIP

Remove UTF8-BOM if available
Ignore comments (using #)
~~Add similar logic for args~~

dnfclas · 2018-01-04T22:25:24Z

All CLA requirements met.

gregg-miskelly · 2018-01-05T00:39:59Z

Looks like a good start to me

gregg-miskelly · 2018-01-23T21:31:39Z

@SebastianPfliegel is this ready for review or are you planning to add support for more things first?

SebastianPfliegel · 2018-01-24T08:21:45Z

It's still WIP. I'll try to finish it today or tomorrow.

gregg-miskelly · 2018-02-02T22:21:11Z

@SebastianPfliegel No rush on this, but just to let you know -- we are just about to start locking down for our next release (1.14). So if you get this done by early next week we can probably include it. Else, no worries, it can ship in a later release.

giard-alexandre · 2018-04-16T17:02:40Z

Any updates on this PR? Since we're using Docker-compose and a .env file at work, this would be a GREAT way for us to consolidate both configs as much as possible. Thanks! 😄

SebastianPfliegel · 2018-04-16T17:36:09Z

@heuristicAL, great to hear my PR is of use. I wasn't able to finish it as dotNet core was broken for my Linux distro, but it has been fixed last week, so I'll give it a try this week to finish it :)

giard-alexandre · 2018-04-16T17:56:11Z

@SebastianPfliegel Great news! If you need any help let me know, I'm willing to give this a try, although my experience developing extensions for VS Code amounts to about.... 0. 👍

SebastianPfliegel · 2018-04-16T17:58:28Z

Haha, was the same for me. That's my first contribution regarding JavaScript/TypeScript ;)

irq · 2018-05-09T12:32:48Z

@SebastianPfliegel Eagerly awaiting this, any updates?

giard-alexandre · 2018-07-12T17:53:45Z

Any updates on this? Would I be wasting my time if I were to fork out and update the PR?

codecov · 2018-07-17T19:09:37Z

Codecov Report

Merging #1951 into master will decrease coverage by 0.3%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   63.63%   63.33%   -0.31%     
==========================================
  Files          88       88              
  Lines        4007     4020      +13     
  Branches      567      570       +3     
==========================================
- Hits         2550     2546       -4     
- Misses       1294     1311      +17     
  Partials      163      163

Flag	Coverage Δ
#integration	`52.65% <0%> (-0.03%)`	⬇️
#unit	`84.66% <ø> (-0.06%)`	⬇️

Impacted Files	Coverage Δ
src/configurationProvider.ts	`17.24% <0%> (-10.54%)`	⬇️
src/observers/OmnisharpLoggerObserver.ts	`100% <0%> (ø)`	⬆️
src/omnisharp/options.ts	`100% <0%> (ø)`	⬆️
src/omnisharp/launcher.ts	`54.16% <0%> (+0.94%)`	⬆️
src/observers/CsharpLoggerObserver.ts	`100% <0%> (+3.63%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82be5e1...aa3214f. Read the comment docs.

SebastianPfliegel · 2018-07-17T19:27:08Z

@heuristicAL & @irq: sorry for letting you wait. I squashed the commits and tested the code thoroughly. It was already skipping remarks (beginning with #).

Here's some examples how the .env file gets parsed:

TEST1=singlevalue
TEST2=two words
TEST3="hey"
TEST4='another test'
TEST5 = space
TEST6      =      lots of space
   TEST7 = space at beginning

#TEST9=just a remark
/TEST10=doesntworkeither

And this is the result:

TEST1: singlevalue
TEST2: two words
TEST3: hey
TEST4: another test
TEST5: space
TEST6: lots of space
TEST7: space at beginning
empty line gets skipped
TEST9 won't parse
TEST10 won't parse

@gregg-miskelly: care to review? :)

gregg-miskelly

Aside from those two small changes, looks good to me. Thanks for taking the time to finish this up.

gregg-miskelly · 2018-07-17T21:27:14Z

src/configurationProvider.ts

+                content.split("\n").forEach(line => {
+                    const r: RegExpMatchArray = line.match(/^\s*([\w\.\-]+)\s*=\s*(.*)?\s*$/);
+
+                    if (r !== null) {


Should we provide some sort of error message if this is null?

(Excluding lines that start with '#')

In reply to: 203184365 [](ancestors = 203184365)

gregg-miskelly · 2018-07-17T21:28:29Z

package-lock.json

@@ -6021,5130 +6021,6 @@
        "once": "1.4.0"
      }
    },
-    "npm": {


I think you want to backout your changes to this file

SebastianPfliegel · 2018-07-23T19:12:38Z

Committed your requested changes. Should I squash them?

gregg-miskelly · 2018-07-23T19:23:46Z

Yes please.

SebastianPfliegel · 2018-07-23T19:41:10Z

Consider it done ;)

SebastianPfliegel · 2018-07-30T09:04:36Z

@gregg-miskelly: were you able to test it?

gregg-miskelly · 2018-07-30T21:59:43Z

@SebastianPfliegel Sorry for the delay. We had CI issues last week and I didn't have time to investigate. I will see if I can get this merged now...

gregg-miskelly · 2018-08-01T00:54:11Z

@akshita31: Would you mind merging this for me once the CI issues are fixed? I am going on vacation. If you need help from the debugger team chuckries is going to try and monitor things.

akshita31 · 2018-08-01T17:51:24Z

@gregg-miskelly Sure, we are reverting to an older omnisharp version instead of the "latest" one for the integration tests. Will merge this, once we get the CI working.

akshita31 · 2018-08-01T18:14:38Z

@SebastianPfliegel The CI issue has been fixed, but the build still fails. I pulled your branch and executed an npm run compile, and found that there is a compile error that is causing the build to fail.

gregg-miskelly · 2018-08-16T22:58:47Z

@SebastianPfliegel thanks so much for doing this! I made more changes to get this to work and created a new PR with both our work -- #2462

I will close this one.

If you have the time, feel free to review my PR.

SebastianPfliegel mentioned this pull request Jan 4, 2018

argsFile and envFile in launch.json #1944

Closed

DustinCampbell requested a review from gregg-miskelly January 23, 2018 17:35

SebastianPfliegel force-pushed the env_file branch from a217781 to 1b0ca96 Compare July 17, 2018 19:09

gregg-miskelly requested changes Jul 17, 2018

View reviewed changes

Parse envFile and pass to debugger

735a5f3

SebastianPfliegel force-pushed the env_file branch from 3ab1f32 to 735a5f3 Compare July 23, 2018 19:40

Merge branch 'master' into env_file

aef802d

gregg-miskelly approved these changes Jul 30, 2018

View reviewed changes

Merge branch 'master' into env_file

aa3214f

gregg-miskelly closed this Aug 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse envFile and pass to debugger #1951

Parse envFile and pass to debugger #1951

SebastianPfliegel commented Jan 4, 2018 •

edited

Loading

dnfclas commented Jan 4, 2018 •

edited

Loading

gregg-miskelly commented Jan 5, 2018

gregg-miskelly commented Jan 23, 2018

SebastianPfliegel commented Jan 24, 2018

gregg-miskelly commented Feb 2, 2018

giard-alexandre commented Apr 16, 2018 •

edited

Loading

SebastianPfliegel commented Apr 16, 2018

giard-alexandre commented Apr 16, 2018

SebastianPfliegel commented Apr 16, 2018

irq commented May 9, 2018

giard-alexandre commented Jul 12, 2018

codecov bot commented Jul 17, 2018 •

edited

Loading

SebastianPfliegel commented Jul 17, 2018

gregg-miskelly left a comment

gregg-miskelly Jul 17, 2018

gregg-miskelly Jul 17, 2018

SebastianPfliegel Jul 23, 2018

gregg-miskelly Jul 17, 2018

SebastianPfliegel Jul 23, 2018

SebastianPfliegel commented Jul 23, 2018

gregg-miskelly commented Jul 23, 2018

SebastianPfliegel commented Jul 23, 2018

SebastianPfliegel commented Jul 30, 2018

gregg-miskelly commented Jul 30, 2018

gregg-miskelly commented Aug 1, 2018

akshita31 commented Aug 1, 2018

akshita31 commented Aug 1, 2018

gregg-miskelly commented Aug 16, 2018

Parse envFile and pass to debugger #1951

Parse envFile and pass to debugger #1951

Conversation

SebastianPfliegel commented Jan 4, 2018 • edited Loading

WIP

dnfclas commented Jan 4, 2018 • edited Loading

gregg-miskelly commented Jan 5, 2018

gregg-miskelly commented Jan 23, 2018

SebastianPfliegel commented Jan 24, 2018

gregg-miskelly commented Feb 2, 2018

giard-alexandre commented Apr 16, 2018 • edited Loading

SebastianPfliegel commented Apr 16, 2018

giard-alexandre commented Apr 16, 2018

SebastianPfliegel commented Apr 16, 2018

irq commented May 9, 2018

giard-alexandre commented Jul 12, 2018

codecov bot commented Jul 17, 2018 • edited Loading

Codecov Report

SebastianPfliegel commented Jul 17, 2018

gregg-miskelly left a comment

Choose a reason for hiding this comment

gregg-miskelly Jul 17, 2018

Choose a reason for hiding this comment

gregg-miskelly Jul 17, 2018

Choose a reason for hiding this comment

SebastianPfliegel Jul 23, 2018

Choose a reason for hiding this comment

gregg-miskelly Jul 17, 2018

Choose a reason for hiding this comment

SebastianPfliegel Jul 23, 2018

Choose a reason for hiding this comment

SebastianPfliegel commented Jul 23, 2018

gregg-miskelly commented Jul 23, 2018

SebastianPfliegel commented Jul 23, 2018

SebastianPfliegel commented Jul 30, 2018

gregg-miskelly commented Jul 30, 2018

gregg-miskelly commented Aug 1, 2018

akshita31 commented Aug 1, 2018

akshita31 commented Aug 1, 2018

gregg-miskelly commented Aug 16, 2018

SebastianPfliegel commented Jan 4, 2018 •

edited

Loading

dnfclas commented Jan 4, 2018 •

edited

Loading

giard-alexandre commented Apr 16, 2018 •

edited

Loading

codecov bot commented Jul 17, 2018 •

edited

Loading