Add support for configuring default startup *.sln in settings.json #2053
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,9 +10,7 @@ install.* | |
|
|
||
| *.vsix | ||
|
|
||
| test/**/singleCsproj/.vscode | ||
| .logs/ | ||
|
|
||
| \.DS_Store | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -401,6 +401,11 @@ | |
| "default": 250, | ||
| "description": "The maximum number of projects to be shown in the 'Select Project' dropdown (maximum 250)." | ||
| }, | ||
| "omnisharp.defaultLaunchSolution": { | ||
| "type": "string", | ||
| "default": null, | ||
| "description": "The name of the default solution used at start up if the repo has multiple. e.g.'MyAwesomeSolution.sln'. Default value is `null` which will cause the first in alphabetical order to be chosen" | ||
|
There was a problem hiding this comment. Nit: This should have a period at the end. |
||
| }, | ||
| "omnisharp.useEditorFormattingSettings": { | ||
| "type": "boolean", | ||
| "default": true, | ||
|
|
@@ -1255,9 +1260,9 @@ | |
| "type": "coreclr", | ||
| "request": "launch", | ||
| "preLaunchTask": "build", | ||
| "program": "^\"\\${workspaceFolder}/bin/Debug/${1:<target-framework>}/${2:<project-name.dll>}\"", | ||
| "args": [], | ||
| "cwd": "^\"\\${workspaceFolder}\"", | ||
| "stopAtEntry": false, | ||
| "console": "internalConsole" | ||
| } | ||
|
|
@@ -1280,9 +1285,9 @@ | |
| "type": "coreclr", | ||
| "request": "launch", | ||
| "preLaunchTask": "build", | ||
| "program": "^\"\\${workspaceFolder}/bin/Debug/${1:<target-framework>}/${2:<project-name.dll>}\"", | ||
| "args": [], | ||
| "cwd": "^\"\\${workspaceFolder}\"", | ||
| "stopAtEntry": false, | ||
| "launchBrowser": { | ||
| "enabled": true, | ||
|
|
@@ -1302,7 +1307,7 @@ | |
| "ASPNETCORE_ENVIRONMENT": "Development" | ||
| }, | ||
| "sourceFileMap": { | ||
| "/Views": "^\"\\${workspaceFolder}/Views\"" | ||
| } | ||
| } | ||
| }, | ||
|
|
@@ -1314,13 +1319,13 @@ | |
| "type": "coreclr", | ||
| "request": "launch", | ||
| "preLaunchTask": "build", | ||
|
There was a problem hiding this comment. All of this part of launch.json is generated from src/tools/OptionsSchema.json. Can you fix it there too? Otherwise this will be lost the next time we run the generator. There was a problem hiding this comment. Looks like this is fixed now in the latest master. |
||
| "program": "^\"\\${workspaceFolder}/bin/Debug/${1:<target-framework>}/${2:<project-name.dll>}\"", | ||
| "args": [], | ||
| "cwd": "^\"\\${workspaceFolder}\"", | ||
| "stopAtEntry": false, | ||
| "console": "internalConsole", | ||
| "pipeTransport": { | ||
| "pipeCwd": "^\"\\${workspaceFolder}\"", | ||
| "pipeProgram": "^\"${3:enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'}\"", | ||
| "pipeArgs": [], | ||
| "debuggerPath": "^\"${4:enter the path for the debugger on the target machine, for example ~/vsdbg/vsdbg}\"" | ||
|
|
@@ -1336,14 +1341,23 @@ | |
| "request": "attach", | ||
| "processId": "^\"\\${command:pickRemoteProcess}\"", | ||
| "pipeTransport": { | ||
| "pipeCwd": "^\"\\${workspaceFolder}\"", | ||
| "pipeProgram": "^\"${1:enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'}\"", | ||
| "pipeArgs": [], | ||
| "debuggerPath": "^\"${2:enter the path for the debugger on the target machine, for example ~/vsdbg/vsdbg}\"" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "windows": { | ||
| "program": "./.debugger/vsdbg-ui.exe" | ||
| }, | ||
| "osx": { | ||
| "program": "./.debugger/vsdbg-ui" | ||
| }, | ||
| "linux": { | ||
| "program": "./.debugger/vsdbg-ui" | ||
| } | ||
|
There was a problem hiding this comment. I'm pretty sure that you don't want these changes in your PR. Is that correct @gregg-miskelly? There was a problem hiding this comment. Not sure how/why those got in there tbh. There was a problem hiding this comment. It can happen when debugging the extension. |
||
| }, | ||
| { | ||
| "type": "clr", | ||
|
|
@@ -2121,6 +2135,15 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "windows": { | ||
| "program": "./.debugger/vsdbg-ui.exe" | ||
| }, | ||
| "osx": { | ||
| "program": "./.debugger/vsdbg-ui" | ||
| }, | ||
| "linux": { | ||
| "program": "./.debugger/vsdbg-ui" | ||
|
There was a problem hiding this comment. I'm pretty sure that you don't want these changes in your PR. Is that correct @gregg-miskelly? There was a problem hiding this comment. @janaka: You need to revert this bit. |
||
| } | ||
| } | ||
| ] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this? It looks like VSCode deprecated workspaceroot for workspacefolder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
workspaceRootwas deprecated when multi-root workspaces were added to VS Code.