A few small option description tweaks #2239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
==========================================
+ Coverage 59.7% 59.75% +0.05%
==========================================
Files 77 77
Lines 3762 3762
Branches 543 545 +2
==========================================
+ Hits 2246 2248 +2
+ Misses 1342 1341 -1
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
| @@ -521,7 +521,7 @@ | |||
| "omnisharp.useMono": { | |||
| "type": "boolean", | |||
| "default": false, | |||
| "description": "Launch OmniSharp with Mono." | |||
| "description": "Launch OmniSharp with Mono. Note that this option is only valid when 'omnisharp.path' is set to an absolute path." | |||
There was a problem hiding this comment.
Is this not true if path is latest or a specific version number?
There was a problem hiding this comment.
From what I understand from the code we are trying to use the mono irrespective of whether the omnisharp.path is set and if set what is the value. The launcher as of now just cares that if the useMono is set then it will try to launch using mono: https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/omnisharp/launcher.ts#L245
There was a problem hiding this comment.
Maybe the docs should explicitly visualize the table we're talking about :)
There was a problem hiding this comment.
@akshita31: Yes, there is essentially a bug that I think we should tweak here. Your PR to make the default OmniSharp use the same infrastructure as everything else actually makes it easier to fix that. I'll go ahead and do it.
|
Closed in favor of #2244 |
No description provided.