Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move invalid CHANGELOG entry into more accurate position #2699

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

jakubfijalkowski
Copy link
Contributor

Hey,

After merging my PR #1877 (thanks!) my then-added CHANGELOG.md entry has been placed under version 1.17.0 which was then-to-be-released, but now is invalid. This PR moves that entry into more appropriate 1.17.2 (if that will be the version released).

@akshita31
Copy link
Contributor

For now let us do "1.18.0"

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #2699 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
+ Coverage    65.2%   65.54%   +0.34%     
==========================================
  Files          99       99              
  Lines        4328     4328              
  Branches      631      631              
==========================================
+ Hits         2822     2837      +15     
+ Misses       1318     1307      -11     
+ Partials      188      184       -4
Flag Coverage Δ
#integration 53.78% <ø> (+0.34%) ⬆️
#unit 84.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/omnisharp/server.ts 70.4% <0%> (+0.34%) ⬆️
src/features/diagnosticsProvider.ts 81.33% <0%> (+1.33%) ⬆️
src/features/codeLensProvider.ts 48.54% <0%> (+1.94%) ⬆️
src/features/completionItemProvider.ts 87.87% <0%> (+9.09%) ⬆️
src/features/documentation.ts 47.61% <0%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 678ea5b...fd9bd33. Read the comment docs.

@akshita31 akshita31 merged commit 358dc3c into dotnet:master Nov 23, 2018
@akshita31
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants